mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 22:01:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: deduplicate pre-attach comment in doConnect

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Alistair Smith
2026-02-10 15:28:18 -08:00
parent 2e2159a9c3
commit bf15eb7955
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/bun.js/bindings/BunDebugger.cpp
View File

@@ -129,15 +129,8 @@ public:
this->hasEverConnected = true;
globalObject->inspectorController().connectFrontend(*this, true, false); // waitingForConnection
// Pre-attach the debugger so that notifyNeedDebuggerBreak() can trigger a pause
// for CDP message dispatch. This is needed when the event loop isn't running
// (e.g., while(true) {}). The debugger would normally be attached by the
// Debugger.enable CDP command, but we can't dispatch CDP messages during
// StopTheWorld (JSC's JSON parser needs GC heap operations that conflict with STW).
// By attaching early, we enable the pause mechanism so messages can be
// dispatched in the normal runWhilePaused loop after STW completes.
// Pre-attach the debugger so that notifyNeedDebuggerBreak() can trigger a pause
// for CDP message dispatch. This only fires on the SIGUSR1 path because --inspect
// Pre-attach the debugger so that schedulePauseAtNextOpportunity() can work
// during the STW callback. This only fires on the SIGUSR1 path because --inspect
// and --inspect-wait already have the debugger attached by JSC at startup
// (globalObject->debugger() is non-null), so the condition is false for those paths.
auto* controllerDebugger = globalObject->inspectorController().debugger();