mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 13:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

pass identifier not ptr

Browse Source
This commit is contained in:
Alistair Smith
2025-05-28 11:30:46 -07:00
parent aa0d8b3baf
commit c9df308835
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/bun.js/bindings/webcore/MessagePort.cpp
View File

@@ -87,16 +87,19 @@ bool MessagePort::isMessagePortAliveForTesting(const MessagePortIdentifier& iden
void MessagePort::notifyMessageAvailable(const MessagePortIdentifier& identifier)
{
std::optional<ScriptExecutionContextIdentifier> scriptExecutionContextIdentifier;
ThreadSafeWeakPtr<MessagePort> weakPort;
{
Locker locker { allMessagePortsLock };
scriptExecutionContextIdentifier = portToContextIdentifier().getOptional(identifier);
weakPort = allMessagePorts().get(identifier);
}
if (!scriptExecutionContextIdentifier)
return;
ScriptExecutionContext::ensureOnContextThread(*scriptExecutionContextIdentifier, [weakPort = WTFMove(weakPort)](auto&) {
ScriptExecutionContext::ensureOnContextThread(*scriptExecutionContextIdentifier, [identifier](auto&) {
ThreadSafeWeakPtr<MessagePort> weakPort;
{
Locker locker { allMessagePortsLock };
weakPort = allMessagePorts().get(identifier);
}
if (RefPtr port = weakPort.get())
port->messageAvailable();
});
@@ -105,16 +108,19 @@ void MessagePort::notifyMessageAvailable(const MessagePortIdentifier& identifier
void MessagePort::notifyPortClosed(const MessagePortIdentifier& identifier)
{
std::optional<ScriptExecutionContextIdentifier> scriptExecutionContextIdentifier;
ThreadSafeWeakPtr<MessagePort> weakPort;
{
Locker locker { allMessagePortsLock };
scriptExecutionContextIdentifier = portToContextIdentifier().getOptional(identifier);
weakPort = allMessagePorts().get(identifier);
}
if (!scriptExecutionContextIdentifier)
return;
ScriptExecutionContext::ensureOnContextThread(*scriptExecutionContextIdentifier, [weakPort = WTFMove(weakPort)](auto&) {
ScriptExecutionContext::ensureOnContextThread(*scriptExecutionContextIdentifier, [identifier](auto&) {
ThreadSafeWeakPtr<MessagePort> weakPort;
{
Locker locker { allMessagePortsLock };
weakPort = allMessagePorts().get(identifier);
}
if (RefPtr port = weakPort.get()) {
// Only dispatch close event if the port has message event listeners
if (port->m_hasMessageEventListener) {