mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 11:59:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(buffer): use correct constructor for buffer.isAscii (#22480)

Browse Source 
### What does this PR do?
The constructor was using `isUtf8` instead of `isAscii`.

Instead of this change maybe we should remove the constructors for
`isAscii` and `isUtf8`. It looks like we do this for most native
functions, but would be more breaking than correcting the current bug.
### How did you verify your code works?
Added a test
This commit is contained in:
Dylan Conway
2025-09-08 00:40:07 +00:00
committed by GitHub
parent 73f0594704
commit cf947fee17
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bun.js/modules/NodeBufferModule.h
View File

@@ -210,7 +210,7 @@ DEFINE_NATIVE_MODULE(NodeBuffer)
put(JSC::Identifier::fromString(vm, "resolveObjectURL"_s), resolveObjectURL);
put(JSC::Identifier::fromString(vm, "isAscii"_s), JSC::JSFunction::create(vm, globalObject, 1, "isAscii"_s, jsBufferConstructorFunction_isAscii, ImplementationVisibility::Public, NoIntrinsic, jsBufferConstructorFunction_isUtf8));
put(JSC::Identifier::fromString(vm, "isAscii"_s), JSC::JSFunction::create(vm, globalObject, 1, "isAscii"_s, jsBufferConstructorFunction_isAscii, ImplementationVisibility::Public, NoIntrinsic, jsBufferConstructorFunction_isAscii));
put(JSC::Identifier::fromString(vm, "isUtf8"_s), JSC::JSFunction::create(vm, globalObject, 1, "isUtf8"_s, jsBufferConstructorFunction_isUtf8, ImplementationVisibility::Public, NoIntrinsic, jsBufferConstructorFunction_isUtf8));
}

1
test/js/node/buffer.test.js
View File

@@ -193,6 +193,7 @@ for (let withOverridenBufferWrite of [false, true]) {
expect(isAscii(new Buffer(""))).toBeTrue();
expect(isAscii(new Buffer([32, 32, 128]))).toBeFalse();
expect(isAscii(new Buffer("What did the 🦊 say?"))).toBeFalse();
expect(new isAscii(new Buffer("What did the 🦊 say?"))).toBeFalse();
expect(isAscii(new Buffer("").buffer)).toBeTrue();
expect(isAscii(new Buffer([32, 32, 128]).buffer)).toBeFalse();
});