mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 13:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

FFI typo (#3973)

Browse Source 
* FFI typo

* add tests

* it was a newline
This commit is contained in:
dave caruso
2023-08-04 16:08:50 -07:00
committed by GitHub
parent bdbc21ff7b
commit d196aa2de6
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/bun/ffi.ts
View File

@@ -57,7 +57,7 @@ const FFIType = {
fn: 17,
};
const suffix = process.platform === "win32" ? ".dll" : process.platform === "darwin" ? ".dylib" : ".so";
const suffix = process.platform === "win32" ? "dll" : process.platform === "darwin" ? "dylib" : "so";
declare const __GlobalBunFFIPtrFunctionForWrapper: typeof ptr;
declare const __GlobalBunCString: typeof CString;

6
src/js/out/InternalModuleRegistryConstants.h
View File

File diff suppressed because one or more lines are too long

7
test/js/bun/ffi/ffi.test.js
View File

@@ -10,6 +10,7 @@ import {
toArrayBuffer,
toBuffer,
viewSource,
suffix,
} from "bun:ffi";
const dlopen = (...args) => {
@@ -20,7 +21,7 @@ const dlopen = (...args) => {
throw err;
}
};
const ok = existsSync("/tmp/bun-ffi-test.dylib");
const ok = existsSync("/tmp/bun-ffi-test." + suffix);
it("ffi print", async () => {
await Bun.write(
@@ -626,3 +627,7 @@ it("dlopen throws an error instead of returning it", () => {
}
expect(err).toBeTruthy();
});
it('suffix does not start with a "."', () => {
expect(suffix).not.toMatch(/^\./);
});