mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[node:http] Fix close() to accept a callback and implement closeAllConnections

Browse Source
This commit is contained in:
Jarred Sumner
2023-05-11 15:09:14 -07:00
parent 77eb61a1fe
commit d67bdb7e9b
1 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/bun.js/http.exports.js
View File

@@ -221,12 +221,30 @@ export class Server extends EventEmitter {
if (callback) this.on("request", callback);
}
close() {
if (this.#server) {
this.emit("close");
this.#server.stop();
this.#server = undefined;
closeAllConnections() {
const server = this.#server;
if (!server) {
return;
}
this.#server = undefined;
server.stop(true);
this.emit("close");
}
closeIdleConnections() {
// not actually implemented
}
close(optionalCallback) {
const server = this.#server;
if (!server) {
if (typeof optionalCallback === "function") process.nextTick(new Error("Server is not running"));
return;
}
this.#server = undefined;
if (typeof optionalCallback === "function") this.once("close", optionalCallback);
this.emit("close");
server.stop();
}
address() {