mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove lstat call in fs.watch (#3836)

Browse Source 
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
This commit is contained in:
Jarred Sumner
2023-07-27 03:34:18 -07:00
committed by GitHub
parent dc0d767f27
commit d7aebc2222
1 changed files with 19 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/bun.js/node/node_fs_watcher.zig
View File

@@ -589,34 +589,30 @@ pub const FSWatcher = struct {
is_file: bool = true,
};
// TODO: switch to using JSC.Maybe to avoid using "unreachable" and improve error messages
fn fdFromAbsolutePathZ(
absolute_path_z: [:0]const u8,
) !PathResult {
var stat = try bun.C.lstat_absolute(absolute_path_z);
var result = PathResult{};
switch (stat.kind) {
.sym_link => {
if (std.fs.openIterableDirAbsoluteZ(absolute_path_z, .{
.access_sub_paths = true,
})) |iterable_dir| {
return PathResult{
.fd = iterable_dir.dir.fd,
.is_file = false,
};
} else |err| {
if (err == error.NotDir) {
var file = try std.fs.openFileAbsoluteZ(absolute_path_z, .{ .mode = .read_only });
result.fd = file.handle;
const _stat = try file.stat();
result.is_file = _stat.kind != .directory;
},
.directory => {
const dir = (try std.fs.openIterableDirAbsoluteZ(absolute_path_z, .{
.access_sub_paths = true,
})).dir;
result.fd = dir.fd;
result.is_file = false;
},
else => {
const file = try std.fs.openFileAbsoluteZ(absolute_path_z, .{ .mode = .read_only });
result.fd = file.handle;
result.is_file = true;
},
return PathResult{
.fd = file.handle,
.is_file = true,
};
} else {
return err;
}
}
return result;
unreachable;
}
pub fn init(args: Arguments) !*FSWatcher {