mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "perf(Buffer.indexOf): use SIMD-optimized search functions (#25745)"

Browse Source
This commit is contained in:
Dylan Conway
2026-01-27 19:52:51 -08:00
parent c9ebb17921
commit daa9eb25db
1 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/bun.js/bindings/JSBuffer.cpp
View File

@@ -82,10 +82,6 @@
extern "C" bool Bun__Node__ZeroFillBuffers;
// SIMD-optimized search functions from highway_strings.cpp
extern "C" void* highway_memmem(const uint8_t* haystack, size_t haystack_len, const uint8_t* needle, size_t needle_len);
extern "C" size_t highway_index_of_char(const uint8_t* haystack, size_t haystack_len, uint8_t needle);
// export fn Bun__inspect_singleline(globalThis: *JSGlobalObject, value: JSValue) bun.String
extern "C" BunString Bun__inspect_singleline(JSC::JSGlobalObject* globalObject, JSC::JSValue value);
@@ -1383,20 +1379,11 @@ static ssize_t indexOfOffset(size_t length, ssize_t offset_i64, ssize_t needle_l
static int64_t indexOf(const uint8_t* thisPtr, int64_t thisLength, const uint8_t* valuePtr, int64_t valueLength, int64_t byteOffset)
{
const size_t haystackLen = static_cast<size_t>(thisLength - byteOffset);
const uint8_t* haystackPtr = thisPtr + byteOffset;
if (valueLength == 1) {
// Use SIMD-optimized single-byte search
size_t result = highway_index_of_char(haystackPtr, haystackLen, valuePtr[0]);
if (result == haystackLen) return -1;
return byteOffset + static_cast<int64_t>(result);
}
// Use SIMD-optimized multi-byte search
void* result = highway_memmem(haystackPtr, haystackLen, valuePtr, static_cast<size_t>(valueLength));
if (result == nullptr) return -1;
return byteOffset + static_cast<int64_t>(static_cast<const uint8_t*>(result) - haystackPtr);
auto haystack = std::span<const uint8_t>(thisPtr, thisLength).subspan(byteOffset);
auto needle = std::span<const uint8_t>(valuePtr, valueLength);
auto it = std::search(haystack.begin(), haystack.end(), needle.begin(), needle.end());
if (it == haystack.end()) return -1;
return byteOffset + std::distance(haystack.begin(), it);
}
static int64_t indexOf16(const uint8_t* thisPtr, int64_t thisLength, const uint8_t* valuePtr, int64_t valueLength, int64_t byteOffset)