mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 05:42:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip flaky macOS x64 node-napi tests in CI (v2) (#18468)

Browse Source
This commit is contained in:
190n
2025-03-25 18:20:08 -07:00
committed by GitHub
parent 9e580f8413
commit db492575c8
1 changed files with 25 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
test/napi/node-napi.test.ts
View File

@@ -1,6 +1,6 @@
import { spawnSync, spawn, Glob } from "bun";
import { beforeAll, describe, expect, it } from "bun:test";
import { bunEnv, bunExe, isBroken, isCI, isIntelMacOS, isMusl } from "harness";
import { bunEnv, bunExe, isBroken, isCI, isIntelMacOS, isMusl, isWindows } from "harness";
import { join, dirname } from "path";
import os from "node:os";
@@ -17,12 +17,6 @@ let failingJsNativeApiTests: string[] = [
// "test_string/test.js",
];
if (isBroken && isIntelMacOS) {
// TODO(@190n)
// these are flaky on Intel Mac
failingJsNativeApiTests.push("test_reference_by_node_api_version/test.js", "test_reference/test.js");
}
// These are the tests from node-api that failed as of commit 83f536f4d, except for those that
// passed in Bun v1.1.34. It'll take some time to get all these to work, as we've been focusing more
// on js-native-api tests so far, and we don't want these tests to pollute CI. But we do want to
@@ -56,8 +50,17 @@ let failingNodeApiTests = [
"test_worker_terminate/test.js",
];
if (process.platform == "win32") {
failingNodeApiTests.push("test_callback_scope/test.js"); // TODO: remove once #12827 is fixed
if (isBroken && isIntelMacOS) {
// TODO(@190n)
// these are flaky on Intel Mac
failingJsNativeApiTests.push("test_reference/test.js");
failingNodeApiTests.push("test_reference_by_node_api_version/test.js");
}
if (isWindows) {
if (isBroken) {
failingNodeApiTests.push("test_callback_scope/test.js"); // TODO: remove once #12827 is fixed
}
for (const i in failingJsNativeApiTests) {
failingJsNativeApiTests[i] = failingJsNativeApiTests[i].replaceAll("/", "\\");
@@ -72,6 +75,19 @@ if (isMusl) {
failingJsNativeApiTests = jsNativeApiTests;
}
for (const t of failingJsNativeApiTests) {
if (!jsNativeApiTests.includes(t)) {
console.error(`attempt to skip ${t} which is not a real js-native-api test`);
process.exit(1);
}
}
for (const t of failingNodeApiTests) {
if (!nodeApiTests.includes(t)) {
console.error(`attempt to skip ${t} which is not a real node-api test`);
process.exit(1);
}
}
beforeAll(async () => {
const directories = jsNativeApiTests
.filter(t => !failingJsNativeApiTests.includes(t))