mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tsfn finalizers

Browse Source
This commit is contained in:
Ben Grant
2024-10-03 18:48:25 -07:00
parent e66ec2a10b
commit dfa2a6b60b
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bun.js/event_loop.zig
View File

@@ -1258,8 +1258,8 @@ pub const EventLoop = struct {
}
pub fn tickImmediateTasks(this: *EventLoop, virtual_machine: *VirtualMachine) void {
JSC.napi.Finalizer.drain(&this.napi_finalizer_queue, this.global);
_ = this.tickQueueWithCount(virtual_machine, "immediate_tasks");
JSC.napi.Finalizer.drain(&this.napi_finalizer_queue, this.global);
}
fn tickConcurrent(this: *EventLoop) void {

4
src/napi/napi.zig
View File

@@ -1480,6 +1480,8 @@ pub const Finalizer = struct {
pub fn drain(this: *Finalizer.Queue, env: napi_env) void {
while (this.readItem()) |*finalizer| {
const handle_scope = NapiHandleScope.open(env, false);
defer if (handle_scope) |scope| scope.close(env);
finalizer.fun.?(env, finalizer.data, finalizer.hint);
}
}
@@ -1642,7 +1644,7 @@ pub const ThreadSafeFunction = struct {
this.unref();
if (this.finalizer.fun) |fun| {
fun(this.event_loop.global, this.finalizer.data, this.ctx);
Finalizer.napi_enqueue_finalizer(fun, this.finalizer.data, this.ctx);
}
if (this.callback == .js) {