mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(jest): fix segfault when passing jest.fn into another jest.fn (#7507)

Browse Source 
Close: #5900
This commit is contained in:
Hanaasagi
2023-12-07 16:41:31 +08:00
committed by GitHub
parent 1bf540efcf
commit dfd4b01a97
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bun.js/bindings/JSMockFunction.cpp
View File

@@ -280,6 +280,8 @@ public:
if (lengthJSValue.isNumber()) {
this->putDirect(vm, vm.propertyNames->length, (lengthJSValue), JSC::PropertyAttribute::DontEnum | JSC::PropertyAttribute::ReadOnly);
}
} else if (auto* fn = jsDynamicCast<JSMockFunction*>(value)) {
nameToUse = fn->get(global, vm.propertyNames->name).toWTFString(global);
} else if (auto* fn = jsDynamicCast<InternalFunction*>(value)) {
nameToUse = fn->name();
} else {

15
test/js/bun/test/mock-fn.test.js
View File

@@ -620,6 +620,21 @@ describe("mock()", () => {
expect(fn).toHaveBeenNthCalledWith(5, 1, undefined);
expect(fn).not.toHaveBeenNthCalledWith(5, 1);
});
it("no segmentation fault when passing jest.fn into another jest.fn, issue#5900", () => {
function foo() {
return true;
}
function bar(fn = jest.fn(foo)) {
expect(fn.getMockName()).toBe("foo");
let newFn = jest.fn(fn);
expect(newFn.getMockName()).toBe("foo");
return newFn;
}
expect(bar()()).toBe(true);
});
});
describe("spyOn", () => {