mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make sure Bun.sleep(Date) doesn't resolve prematurely (#8950)

Browse Source 
* fix: make sure Bun.sleep(Date) doesn't return prematurely

Fixes #8834.

This makes Bun.sleep(new Date(x)) fulfill its promise only when
Date.now() >= x.

* resolve test now #8834 is fixed

11 ms is in fact the right limit.

---------

Co-authored-by: John-David Dalton <john.david.dalton@gmail.com>
This commit is contained in:
argosphil
2024-02-17 02:32:37 +00:00
committed by GitHub
parent 135de4dff7
commit e2c92c69b5
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bun.js/bindings/BunObject.cpp
View File

@@ -352,8 +352,8 @@ JSC_DEFINE_HOST_FUNCTION(functionBunSleep,
if (millisecondsValue.inherits<JSC::DateInstance>()) {
auto now = MonotonicTime::now();
auto milliseconds = jsCast<JSC::DateInstance*>(millisecondsValue)->internalNumber() - now.approximateWallTime().secondsSinceEpoch().milliseconds();
millisecondsValue = JSC::jsNumber(milliseconds > 0 ? milliseconds : 0);
double milliseconds = jsCast<JSC::DateInstance*>(millisecondsValue)->internalNumber() - now.approximateWallTime().secondsSinceEpoch().milliseconds();
millisecondsValue = JSC::jsNumber(milliseconds > 0 ? std::ceil(milliseconds) : 0);
}
if (!millisecondsValue.isNumber()) {

12
test/js/web/timers/setTimeout.test.js
View File

@@ -152,9 +152,15 @@ it("Bun.sleep works with a Date object", async () => {
var ten_ms = new Date();
ten_ms.setMilliseconds(ten_ms.getMilliseconds() + 12);
await Bun.sleep(ten_ms);
// TODO: Fix https://github.com/oven-sh/bun/issues/8834
// This should be .toBeGreaterThan(11), or maybe even 12
expect(performance.now() - now).toBeGreaterThan(10);
expect(performance.now() - now).toBeGreaterThan(11);
});
it("Bun.sleep(Date) fulfills after Date", async () => {
let ten_ms = new Date();
ten_ms.setMilliseconds(ten_ms.getMilliseconds() + 12);
await Bun.sleep(ten_ms);
let now = new Date();
expect(+now).toBeGreaterThanOrEqual(+ten_ms);
});
it("node.js timers/promises setTimeout propagates exceptions", async () => {