mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly ref/unref blobs before extracting the value (#3755)

Browse Source 
* Explicitly ref/unref blobs before extracting the value

* ✂️

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
This commit is contained in:
Jarred Sumner
2023-07-22 22:20:10 -07:00
committed by GitHub
parent 601fd3ead5
commit e2e44661c2
1 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/bun.js/webcore/blob.zig
View File

@@ -790,6 +790,10 @@ pub const Blob = struct {
}
}
var input_store: ?*Store = if (path_or_blob == .blob) path_or_blob.blob.store else null;
if (input_store) |st| st.ref();
defer if (input_store) |st| st.deref();
var needs_async = false;
if (data.isString()) {
@@ -973,6 +977,17 @@ pub const Blob = struct {
};
};
var destination_store = destination_blob.store;
if (destination_store) |store| {
store.ref();
}
defer {
if (destination_store) |store| {
store.deref();
}
}
return writeFileWithSourceDestination(ctx, &source_blob, &destination_blob);
}
@@ -2503,6 +2518,9 @@ pub const Blob = struct {
globalThis: *JSC.JSGlobalObject,
_: *JSC.CallFrame,
) callconv(.C) JSC.JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toString(globalThis, .clone), globalThis);
}
@@ -2510,6 +2528,9 @@ pub const Blob = struct {
this: *Blob,
globalObject: *JSC.JSGlobalObject,
) JSC.JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toString(globalObject, .transfer), globalObject);
}
@@ -2518,6 +2539,10 @@ pub const Blob = struct {
globalThis: *JSC.JSGlobalObject,
_: *JSC.CallFrame,
) callconv(.C) JSC.JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toJSON(globalThis, .share), globalThis);
}
@@ -2525,6 +2550,10 @@ pub const Blob = struct {
this: *Blob,
globalThis: *JSC.JSGlobalObject,
) JSC.JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toArrayBuffer(globalThis, .transfer), globalThis);
}
@@ -2533,6 +2562,9 @@ pub const Blob = struct {
globalThis: *JSC.JSGlobalObject,
_: *JSC.CallFrame,
) callconv(.C) JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toArrayBuffer(globalThis, .clone), globalThis);
}
@@ -2541,6 +2573,10 @@ pub const Blob = struct {
globalThis: *JSC.JSGlobalObject,
_: *JSC.CallFrame,
) callconv(.C) JSValue {
var store = this.store;
if (store) |st| st.ref();
defer if (store) |st| st.deref();
return promisified(this.toFormData(globalThis, .temporary), globalThis);
}