mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 03:48:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug in util/types.{isGeneratorFunction,isAsyncFunction}

Browse Source
This commit is contained in:
Jarred Sumner
2023-08-30 00:19:39 -07:00
parent e3dc5b6b4c
commit f24ca39004
2 changed files with 44 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/bun.js/modules/NodeUtilTypesModule.h
View File

@@ -123,8 +123,28 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionIsRegExp, (JSC::JSGlobalObject * globalObject
}
JSC_DEFINE_HOST_FUNCTION(jsFunctionIsAsyncFunction, (JSC::JSGlobalObject * globalObject, JSC::CallFrame* callframe))
{
GET_FIRST_CELL
return JSValue::encode(jsBoolean(JSValue::strictEqual(globalObject, JSValue(globalObject->asyncFunctionPrototype()), cell->getObject()->getPrototype(cell->getObject(), globalObject))));
GET_FIRST_VALUE
auto* function = jsDynamicCast<JSFunction*>(value);
if (!function)
return JSValue::encode(jsBoolean(false));
auto *executable = function->jsExecutable();
if (!executable)
return JSValue::encode(jsBoolean(false));
if (executable->isAsyncGenerator()) {
return JSValue::encode(jsBoolean(true));
}
auto& vm = globalObject->vm();
auto proto = function->getPrototype(vm, globalObject);
if (!proto.isCell()) {
return JSValue::encode(jsBoolean(false));
}
auto *protoCell = proto.asCell();
return JSValue::encode(jsBoolean(protoCell->inherits<AsyncFunctionPrototype>()));
}
JSC_DEFINE_HOST_FUNCTION(jsFunctionIsGeneratorFunction, (JSC::JSGlobalObject * globalObject, JSC::CallFrame* callframe))
{
@@ -137,13 +157,13 @@ JSC_DEFINE_HOST_FUNCTION(jsFunctionIsGeneratorFunction, (JSC::JSGlobalObject * g
if (!executable)
return JSValue::encode(jsBoolean(false));
return JSValue::encode(jsBoolean(executable->isGenerator()));
return JSValue::encode(jsBoolean(executable->isGenerator() || executable->isAsyncGenerator()));
}
JSC_DEFINE_HOST_FUNCTION(jsFunctionIsGeneratorObject, (JSC::JSGlobalObject * globalObject, JSC::CallFrame* callframe))
{
GET_FIRST_CELL
return JSValue::encode(jsBoolean(cell->type() == JSGeneratorType));
return JSValue::encode(jsBoolean(cell->type() == JSGeneratorType || cell->type() == JSAsyncGeneratorType));
}
JSC_DEFINE_HOST_FUNCTION(jsFunctionIsPromise, (JSC::JSGlobalObject * globalObject, JSC::CallFrame* callframe))
{

22
test/js/node/util/test-util-types.test.js
View File

@@ -24,9 +24,8 @@ for (const [value, _method] of [
[Object(BigInt(0)), "isBigIntObject"],
[new Error(), "isNativeError"],
[new RegExp()],
[async function () {}, "isAsyncFunction"],
[function* () {}, "isGeneratorFunction"],
[(function* () {})(), "isGeneratorObject"],
[(async function* () {})(), "isGeneratorObject"],
[Promise.resolve()],
[new Map()],
[new Set()],
@@ -248,3 +247,22 @@ test("isBoxedPrimitive", () => {
}
}
// */
test("isAsyncFunction", () => {
for (let fn of [async function asyncFn() {}, async function* asyncGeneratorFn() {}]) {
expect(types.isAsyncFunction(fn)).toBeTrue();
}
for (let fn of [function normal() {}, function* generatorFn() {}]) {
expect(types.isAsyncFunction(fn)).toBeFalse();
}
});
test("isGeneratorFunction", () => {
for (let fn of [function* generator() {}, async function* asyncGenerator() {}]) {
expect(types.isGeneratorFunction(fn)).toBeTrue();
}
for (let fn of [function normal() {}, async function asyncFn() {}]) {
expect(types.isGeneratorFunction(fn)).toBeFalse();
}
});