mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix strangeness with Bun.env keys

Browse Source
This commit is contained in:
Jarred Sumner
2022-11-27 06:17:59 -08:00
parent faad250559
commit f891d1df50
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/bun.js/javascript_core_c_api.zig
View File

@@ -64,17 +64,16 @@ pub const OpaqueJSString = opaque {
return JSStringCreateWithUTF8CString("");
}
if (zig_str.is16Bit()) {
return JSStringCreateWithCharacters(zig_str.utf16SliceAligned().ptr, zig_str.len);
if (zig_str.isUTF8()) {
return JSValueToStringCopy(
bun.JSC.VirtualMachine.vm.global,
zig_str.toValueGC(bun.JSC.VirtualMachine.vm.global).asObjectRef(),
null,
);
}
if (zig_str.isUTF8()) {
// this is super inefficient
if (bun.strings.toUTF16Alloc(allocator, zig_str.slice(), false) catch unreachable) |utf16| {
const cloned = JSStringCreateWithCharacters(utf16.ptr, utf16.len);
allocator.free(utf16);
return cloned;
}
if (zig_str.is16Bit()) {
return JSStringCreateWithCharacters(zig_str.utf16SliceAligned().ptr, zig_str.len);
}
// also extremely inefficient
@@ -512,3 +511,5 @@ const JSStringIterator_ = extern struct {
// not official api functions
pub extern "c" fn JSCInitialize() void;
pub extern "c" fn JSObjectGetProxyTarget(JSObjectRef) JSObjectRef;