mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct pool node type and add validation for path buffer pool

Browse Source 
Two fixes:
1. In http/zlib.zig: Fix the type annotation for the pool node from
   `BufferPool.Node` (value type) to `*BufferPool.Node` (pointer type).
   The @fieldParentPtr builtin returns a pointer, not a value.

2. In path_buffer_pool.zig: Add debug assertions to validate the allocator
   pointer after computing the node from @fieldParentPtr. This helps catch
   cases where an invalid buffer pointer is passed to put(), which would
   cause @fieldParentPtr to compute garbage and lead to crashes like
   "index out of bounds" when the garbage pointer is dereferenced.

This addresses a Windows-specific crash with error "index out of bounds:
index 49151, len 49151" occurring in path_buffer_pool.put().

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Bot
2026-01-20 02:20:00 +00:00
parent 716801e92d
commit fa0c945d91
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/http/zlib.zig
View File

@@ -9,7 +9,7 @@ pub fn get(allocator: std.mem.Allocator) *MutableString {
pub fn put(mutable: *MutableString) void {
mutable.reset();
var node: BufferPool.Node = @fieldParentPtr("data", mutable);
const node: *BufferPool.Node = @fieldParentPtr("data", mutable);
node.release();
}

8
src/paths/path_buffer_pool.zig
View File

@@ -13,7 +13,13 @@ fn PathBufferPoolT(comptime T: type) type {
pub fn put(buffer: *const T) void {
// there's no deinit function on T so @constCast is fine
var node: *Pool.Node = @alignCast(@fieldParentPtr("data", @constCast(buffer)));
const node: *Pool.Node = @alignCast(@fieldParentPtr("data", @constCast(buffer)));
// Validate the allocator pointer to catch use-after-free or invalid buffer pointers.
// A valid allocator should have non-null ptr and vtable fields.
if (comptime Environment.isDebug) {
bun.debugAssert(@intFromPtr(node.allocator.ptr) != 0);
bun.debugAssert(@intFromPtr(node.allocator.vtable) != 0);
}
node.release();
}