Commit Graph

13561 Commits

Author SHA1 Message Date
Ciro Spaciari
c226a947c9 dont touch JS in the finalizer 2025-09-11 17:10:54 -07:00
Ciro Spaciari
a6d749276c dont make it an impossible to catch error 2025-09-10 23:18:49 -07:00
Ciro Spaciari
d83103fe49 actually handle the exceptions here 2025-09-10 23:15:39 -07:00
Ciro Spaciari
4400f39b30 dont do weird stuff 2025-09-10 22:47:57 -07:00
Ciro Spaciari
2bd01af7e8 fix js tag 2025-09-10 22:46:25 -07:00
Ciro Spaciari
b616fe1db6 wip 2025-09-10 22:42:14 -07:00
Ciro Spaciari
b4a9f5f0ff no need to use tryGet if we have the callframe this value 2025-09-10 22:15:18 -07:00
Ciro Spaciari
ca80e070de remove .zero from JSref 2025-09-10 22:05:27 -07:00
Ciro Spaciari
2b66c6f4a4 opsie 2025-09-10 22:01:12 -07:00
Ciro Spaciari
a39179a109 remove allowGC 2025-09-10 21:36:11 -07:00
Ciro Spaciari
5ddc772c50 opsie 2025-09-10 21:31:11 -07:00
Ciro Spaciari
324c72c537 more 2025-09-10 21:29:22 -07:00
Ciro Spaciari
019ccc338d queueMicrotask again 2025-09-10 21:18:02 -07:00
Ciro Spaciari
6cc1e75d0f Merge branch 'main' into ciro/fix-onclose 2025-09-10 21:03:50 -07:00
avarayr
b3f5dd73da http(proxy): preserve TLS record ordering in proxy tunnel writes (#22417)
### What does this PR do?

Fixes a TLS corruption bug in CONNECT proxy tunneling for HTTPS uploads.
When a large request body is sent over a tunneled TLS connection, the
client could interleave direct socket writes with previously buffered
encrypted bytes, causing TLS records to be emitted out-of-order. Some
proxies/upstreams detect this as a MAC mismatch and terminate with
SSLV3_ALERT_BAD_RECORD_MAC, which surfaced to users as ECONNRESET ("The
socket connection was closed unexpectedly").

This change makes `ProxyTunnel.write` preserve strict FIFO ordering of
encrypted bytes: if any bytes are already buffered, we enqueue new bytes
instead of calling `socket.write` directly. Flushing continues
exclusively via `onWritable`, which writes the buffered stream in order.
This eliminates interleaving and restores correctness for large proxied
HTTPS POST requests.

### How did you verify your code works?

- Local reproduction using a minimal script that POSTs ~20MB over HTTPS
via an HTTP proxy (CONNECT):
- Before: frequent ECONNRESET. With detailed SSL logs, upstream sent
`SSLV3_ALERT_BAD_RECORD_MAC`.
  - After: requests complete successfully. Upstream responds as expected
  
- Verified small bodies and non-proxied HTTPS continue to work.
- Verified no linter issues and no unrelated code changes. The edit is
isolated to `src/http/ProxyTunnel.zig` and only affects the write path
to maintain TLS record ordering.

Rationale: TLS record boundaries must be preserved; mixing buffered data
with immediate writes risks fragmenting or reordering records under
backpressure. Enqueuing while buffered guarantees FIFO semantics and
avoids record corruption.


fixes: 
#17434

#18490 (false fix in corresponding pr)

---------

Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-09-10 21:02:23 -07:00
Ciro Spaciari
e5cc5d5b4b fix test-queue-microtask 2025-09-10 20:53:15 -07:00
robobun
a37b858993 Add debug-only network traffic logging via BUN_RECV and BUN_SEND env vars (#21890)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Meghan Denny <meghan@bun.sh>
2025-09-10 20:52:18 -07:00
Ciro Spaciari
bb85cc40a7 allow no asyncContext 2025-09-10 20:08:39 -07:00
Ciro Spaciari
00ce0847d9 opsie 2025-09-10 19:48:16 -07:00
Ciro Spaciari
07631e0742 test 2025-09-10 19:18:36 -07:00
robobun
09c56c8ba8 Fix PostgreSQL StringBuilder assertion failure with empty error messages (#22558)
## Summary
- Fixed a debug build assertion failure in PostgreSQL error handling
when all error message fields are empty
- Added safety check before calling `StringBuilder.allocatedSlice()` to
handle zero-length messages
- Added regression test to prevent future occurrences

## The Problem
When PostgreSQL sends an error response with completely empty message
fields, the `ErrorResponse.toJS` function would:
1. Calculate `b.cap` but end up with `b.len = 0` (no actual content)
2. Call `b.allocatedSlice()[0..b.len]` unconditionally
3. Trigger an assertion in `StringBuilder.allocatedSlice()` that
requires `cap > 0`

This only affected debug builds since the assertion is compiled out in
release builds.

## The Fix
Check if `b.len > 0` before calling `allocatedSlice()`. If there's no
content, use an empty string instead.

## Test Plan
- [x] Added regression test that triggers the exact crash scenario
- [x] Verified test crashes without the fix (debug build)
- [x] Verified test passes with the fix
- [x] Confirmed release builds were not affected

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-10 18:47:50 -07:00
Ciro Spaciari
155f0a8bbb Merge branch 'main' into ciro/fix-onclose 2025-09-10 18:35:13 -07:00
Jarred Sumner
6e3349b55c Make the error slightly better 2025-09-10 18:33:41 -07:00
Ciro Spaciari
61bd3e67da Merge branch 'main' into ciro/fix-onclose 2025-09-10 17:56:00 -07:00
github-actions[bot]
2162837416 deps: update hdrhistogram to 0.11.9 (#22455)
## What does this PR do?

Updates hdrhistogram to version 0.11.9

Compare:
8dcce8f685...be60a9987e

Auto-updated by [this
workflow](https://github.com/oven-sh/bun/actions/workflows/update-hdrhistogram.yml)

Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com>
2025-09-10 17:37:05 -07:00
robobun
b9f6a908f7 Fix tarball URL corruption in package manager (#22523)
## What does this PR do?

Fixes a bug where custom tarball URLs get corrupted during installation,
causing 404 errors when installing packages from private registries.

## How did you test this change?

- Added test case in `test/cli/install/bun-add.test.ts` that reproduces
the issue with nested tarball dependencies
- Verified the test fails without the fix and passes with it
- Tested with debug build to confirm the fix resolves the URL corruption

## The Problem

When installing packages from custom tarball URLs, the URLs were getting
mangled with cache folder patterns. The issue had two root causes:

1. **Temporary directory naming**: The extract_tarball.zig code was
including the full URL (including protocol) in temp directory names,
causing string truncation issues with StringOrTinyString's 31-byte limit

2. **Empty package names**: Tarball dependencies with empty package
names weren't being properly handled during deduplication, causing
incorrect package lookups

## The Fix

1. **In extract_tarball.zig**: Now properly extracts just the filename
from URLs using `std.fs.path.basename()` instead of including the full
URL in temp directory names

2. **In PackageManagerEnqueue.zig**: Added handling for empty package
names in tarball dependencies by falling back to the dependency name

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-09-10 17:36:23 -07:00
Ciro Spaciari
8a64dd86c6 more 2025-09-10 17:04:41 -07:00
Ciro Spaciari
a9a56e6230 Merge branch 'main' into ciro/fix-onclose 2025-09-10 16:21:43 -07:00
Ciro Spaciari
477aa56aa4 Ciro/fix onclose refactor (#22556)
### What does this PR do?

### How did you verify your code works?
2025-09-10 16:20:51 -07:00
Samyar
4b5551d230 Update nextjs.md for create next-app (#21853)
### What does this PR do?
Updating documentation for `bun create next-app` to be just as the
latest version of `create next-app`.

* App Router is no longer experimental
*  TailwindCSS has been added

### How did you verify your code works?
I verified the changes by making sure the it's correct.
2025-09-10 02:12:22 -07:00
Jarred Sumner
1a5660ba39 Merge branch 'main' into ciro/fix-onclose 2025-09-10 00:32:56 -07:00
Jarred Sumner
e1505b7143 Use JSC::Integrity:: auditCellFully in bindings (#22538)
### What does this PR do?

### How did you verify your code works?
2025-09-10 00:31:54 -07:00
Jarred Sumner
6611983038 Revert "Redis PUB/SUB (#21728)"
This reverts commit dc3c8f79c4.
2025-09-09 23:31:07 -07:00
robobun
d7ca10e22f Remove unused function/class names when minifying (#22492)
## Summary
- Removes unused function and class expression names when
`--minify-syntax` is enabled during bundling
- Adds `--keep-names` flag to preserve original names when minifying
- Matches esbuild's minification behavior

## Problem
When minifying with `--minify-syntax`, Bun was keeping function and
class expression names even when they were never referenced, resulting
in larger bundle sizes compared to esbuild.

**Before:**
```js
export var AB = function A() { };
// Bun output: var AB = function A() {};
// esbuild output: var AB = function() {};
```

## Solution
This PR adds logic to remove unused function and class expression names
during minification, matching esbuild's behavior. Names are only removed
when:
- `--minify-syntax` is enabled
- Bundling is enabled (not transform-only mode)
- The scope doesn't contain direct eval (which could reference the name
dynamically)
- The symbol's usage count is 0

Additionally, a `--keep-names` flag has been added to preserve original
names when desired (useful for debugging or runtime reflection).

## Testing
- Updated existing test in `bundler_minify.test.ts` 
- All transpiler tests pass
- Manually verified output matches esbuild for various cases

## Examples
```bash
# Without --keep-names (names removed)
bun build --minify-syntax input.js
# var AB = function() {}

# With --keep-names (names preserved)  
bun build --minify-syntax --keep-names input.js
# var AB = function A() {}
```

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-09-09 23:29:39 -07:00
Ciro Spaciari
8eb6b933b6 revert this 2025-09-09 22:56:10 -07:00
Ciro Spaciari
2cc90a7615 more 2025-09-09 22:53:29 -07:00
Ciro Spaciari
7d7c3daccf more 2025-09-09 22:50:21 -07:00
Ciro Spaciari
e557195dde opsie 2025-09-09 22:22:39 -07:00
Ciro Spaciari
32d5797866 opsie 2025-09-09 22:20:18 -07:00
Marko Vejnovic
dc3c8f79c4 Redis PUB/SUB (#21728)
### What does this PR do?

The goal of this PR is to introduce PUB/SUB functionality to the
built-in Redis client. Based on the fact that the current Redis API does
not appear to have compatibility with `io-redis` or `redis-node`, I've
decided to do away with existing APIs and API compatibility with these
existing libraries.

I have decided to base my implementation on the [`redis-node` pub/sub
API](https://github.com/redis/node-redis/blob/master/docs/pub-sub.md).



### How did you verify your code works?

I've written a set of unit tests to hopefully catch the major use-cases
of this feature. They all appear to pass:

<img width="368" height="71" alt="image"
src="https://github.com/user-attachments/assets/36527386-c8fe-47f6-b69a-a11d4b614fa0"
/>


#### Future Improvements

I would have a lot more confidence in our Redis implementation if we
tested it with a test suite running over a network which emulates a high
network failure rate. There are large amounts of edge cases that are
worthwhile to grab, but I think we can roll that out in a future PR.

### Future Tasks

- [ ] Tests over flaky network
- [ ] Use the custom private members over `_<member>`.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: Alistair Smith <hi@alistair.sh>
2025-09-09 22:13:25 -07:00
Ciro Spaciari
bca76bf378 opsie 2025-09-09 21:57:03 -07:00
Ciro Spaciari
75fde6ce45 more 2025-09-09 21:48:55 -07:00
Alistair Smith
3ee477fc5b fix: scanner on update, install, remove, uninstall and add, and introduce the pm scan command (#22193)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-09-09 21:42:01 -07:00
Ciro Spaciari
6d789e2eb7 opsie 2025-09-09 21:11:23 -07:00
Ciro Spaciari
09099b3747 test without microtask 2025-09-09 21:10:40 -07:00
Ciro Spaciari
1c0ae14239 lets go back and test it again 2025-09-09 21:08:38 -07:00
Jarred Sumner
25834afe9a Fix build 2025-09-09 21:03:31 -07:00
Jarred Sumner
7caaf434e9 Fix build 2025-09-09 21:02:21 -07:00
taylor.fish
edf13bd91d Refactor BabyList (#22502)
(For internal tracking: fixes STAB-1129, STAB-1145, STAB-1146,
STAB-1150, STAB-1126, STAB-1147, STAB-1148, STAB-1149, STAB-1158)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
2025-09-09 20:41:10 -07:00
Ciro Spaciari
ec1fc80111 use bool instead of i32 here 2025-09-09 20:24:01 -07:00