Commit Graph

13406 Commits

Author SHA1 Message Date
autofix-ci[bot]
2d7bc20d3c [autofix.ci] apply automated fixes 2025-08-30 03:07:12 +00:00
Claude Bot
f72c094580 Fix TOML.stringify test failures
- Fix error handling to throw for null/undefined at root level (TOML requires object root)
- Fix argument parsing to properly detect when no arguments passed vs undefined argument
- Update array test snapshot to match actual output format (remove extra leading newline)
- All functionality works correctly: deep nesting, arrays, complex objects, round-trips

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-30 03:05:10 +00:00
Claude Bot
0481a6bd96 Fix banned word usage: replace .arguments_old() with .argumentsAsArray()
- Replace deprecated .arguments_old() calls with .argumentsAsArray()
- Remove unnecessary empty argument checking, let system handle naturally
- Update banned words limit since we reduced usage count

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-29 09:27:51 +00:00
Claude Bot
ba5de42631 Simplify TOML.stringify to single-parameter API
Remove confusing multi-parameter signature that didn't actually do anything useful:
- TOML has fixed formatting rules, so space parameter was pointless
- Replacer parameter just threw an error anyway
- Cleaner API: just TOML.stringify(value) like it should be

Updated:
- Function signature to accept only 1 parameter instead of 3
- TypeScript definitions to match the actual API
- Tests to remove multi-parameter test cases

This makes the API much more intuitive and less confusing for users.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-29 09:15:38 +00:00
Michael H
c91caa9e59 Merge branch 'main' into claude/toml-stringify 2025-08-29 19:00:28 +10:00
Claude Bot
2b8fe0bd2f Improve TOML.stringify documentation with actual output example
- Show the actual TOML output in the example instead of explaining what doesn't work
- Simplify parameter descriptions to be less confusing
- Focus on what the function does rather than what it doesn't support

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-29 08:59:32 +00:00
autofix-ci[bot]
c4648e5cc5 [autofix.ci] apply automated fixes 2025-08-29 08:57:11 +00:00
Claude Bot
bdefd42cf8 Simplify TOML.stringify TypeScript signature to single overload
Remove confusing function overloads and use a single, clear signature
that matches the actual implementation. The API supports JSON.stringify-style
parameters but with clear documentation about what's supported.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-29 08:55:34 +00:00
autofix-ci[bot]
ab85b8597f [autofix.ci] apply automated fixes 2025-08-29 08:54:53 +00:00
Claude Bot
8e06c89421 Simplify Bun.TOML.stringify API to match JSON.stringify pattern
- Remove complex options like `inlineTables` to keep API simple and focused
- Follow JSON.stringify(value, replacer, space) signature but ignore replacer/space
- Improve nested object handling with proper dotted table paths
- Add comprehensive tests for deeply nested objects and round-trip compatibility
- Throw error for unsupported replacer parameter (following YAML.stringify pattern)
- Update TypeScript definitions to reflect simplified API

The API is now much cleaner and matches the pattern established by Bun.YAML.stringify:
- Single parameter: `TOML.stringify(obj)`
- JSON.stringify-like: `TOML.stringify(obj, null, space)` (space ignored)
- Proper error for replacer: `TOML.stringify(obj, fn)` throws

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-29 08:52:12 +00:00
Jarred Sumner
e395dec309 Add mysql bench from mariadb 2025-08-29 01:19:25 -07:00
Ciro Spaciari
ff6af0e2f7 fix(Bun.SQL) delay postgres promise resolve for prepared statements (#22090)
### What does this PR do?
fixes https://github.com/oven-sh/bun/issues/21945
### How did you verify your code works?
Run the code bellow and will be way harder the encounter the same
problem (I got it 1 times after 10 tries the same effect as Bun.sleep
mentioned before)

```ts
const sql = new Bun.SQL("postgres://localhost");
using conn1 = await sql.reserve();
using conn2 = await sql.reserve();

await sql`DROP TABLE IF EXISTS test1`;
await sql`CREATE TABLE IF NOT EXISTS test1 (
id INTEGER PRIMARY KEY GENERATED ALWAYS AS IDENTITY,
uuid UUID NOT NULL
)`;
await sql`INSERT INTO test1 (uuid) VALUES (gen_random_uuid())`;
type Row = {
  id: number;
  uuid: string;
};

for (let i = 0; i < 100_000; i++) {
  const [original]: Array<Row> = await conn1`SELECT id, uuid FROM test1 LIMIT 1`;

  const [updated]: Array<Row> =
    await conn1`UPDATE test1 SET uuid = gen_random_uuid() WHERE id = ${original.id} RETURNING id, uuid`;

  const [retrieved]: Array<Row> = await conn2`SELECT id, uuid FROM test1 WHERE id = ${original.id}`;

  if (retrieved.uuid !== updated.uuid) {
    console.log("Expected retrieved and updated to match", retrieved, updated, i);
    break;
  }
}

```
2025-08-29 01:03:43 -07:00
Ciro Spaciari
1085908386 fix(Bun.SQL) MYSQL fix old auth and auth switch + add lastInsertRowid and affectedRows (#22132)
### What does this PR do?

add `lastInsertRowid` (matching SQLite)
add `affectedRows`
fix `mysql_native_password` deprecated authentication
fix AuthSwitch
Fixes:
https://github.com/oven-sh/bun/issues/22178#issuecomment-3228716080
### How did you verify your code works?
tests

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-29 01:03:17 -07:00
Ciro Spaciari
a56488f221 fix(Bun.SQL) handle better BIT(1) in MySQL (#22224)
### What does this PR do?
Fix handling BIT(1) and BIT(N) on binary protocol and text protocol, now
behavior is consistent
### How did you verify your code works?
Tests
2025-08-28 19:14:53 -07:00
Jarred Sumner
fe8f8242fd Make BoundedArray more compact, shrink Data in sql from 32 bytes to 24 bytes (#22210)
### What does this PR do?

- Instead of storing `len` in `BoundedArray` as a `usize`, store it as
either a `u8` or ` u16` depending on the `buffer_capacity`
- Copy-paste `BoundedArray` from the standard library into Bun's
codebase as it was removed in
https://github.com/ziglang/zig/pull/24699/files#diff-cbd8cbbc17583cb9ea5cc0f711ce0ad447b446e62ea5ddbe29274696dce89e4f
and we will probably continue using it

### How did you verify your code works?

Ran `bun run zig:check`

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: taylor.fish <contact@taylor.fish>
2025-08-28 17:34:35 -07:00
pfg
c69ed120e9 Rename some instances of latin1 to cp1252 (#22059)
in JS, `new TextDecoder("latin1").decode(...)` uses cp1252. In python,
latin1 is half-width utf-16. In our code, latin1 typically refers to
half-width utf-16 because JavaScriptCore uses that for most strings, but
sometimes it refers to cp1252. Rename the cp1252 functions to be called
cp1252

Also fixes an issue where Buffer.from with utf-16le would sometimes
output the wrong value:

```js
$> bun -p "Buffer.from('\x80', 'utf-16le')"
<Buffer ac 20>
$> node -p "Buffer.from('\x80', 'utf-16le')"
<Buffer 80 00>
$> bun-debug -p "Buffer.from('\x80', 'utf-16le')"
<Buffer 80 00>
```
2025-08-28 17:28:38 -07:00
robobun
edea077947 Fix env_loader allocator threading issue with BUN_INSPECT_CONNECT_TO (#22206)
## Summary
- Fixed allocator threading violation when `BUN_INSPECT_CONNECT_TO` is
set
- Created thread-local `env_loader` with proper allocator isolation in
debugger thread
- Added regression test to verify the fix works correctly

## Problem
When `BUN_INSPECT_CONNECT_TO` environment variable is set, Bun creates a
debugger thread that spawns its own `VirtualMachine` instance.
Previously, this VM would fall back to the global `DotEnv.instance`
which was created with the main thread's allocator, causing threading
violations when the debugger thread accessed environment files via
`--env-file` or other env loading operations.

## Solution
Modified `startJSDebuggerThread` in `src/bun.js/Debugger.zig` to:
1. Create a thread-local `DotEnv.Map` and `DotEnv.Loader` using the
debugger thread's allocator
2. Pass this thread-local `env_loader` to `VirtualMachine.init()` to
ensure proper allocator isolation
3. Prevent sharing of allocators across threads

## Test plan
- [x] Added regression test in
`test/regression/issue/test_env_loader_threading.test.ts`
- [x] Verified basic Bun functionality still works
- [x] Test passes with both normal execution and with
`BUN_INSPECT_CONNECT_TO` set

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 17:16:37 -07:00
Meghan Denny
669b34ff6c node: fix exception check validator errors in http_parser (#22180)
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 15:06:03 -07:00
Meghan Denny
eb7727819a node:util: move deprecate to internal file so its faster to import (#22197)
Co-authored-by: Meghan Denny <meghan@bun.com>
2025-08-28 15:05:52 -07:00
autofix-ci[bot]
4e3ee84c87 [autofix.ci] apply automated fixes 2025-08-28 11:25:28 +00:00
Claude Bot
e587194b3a Improve TOML.stringify API with TypeScript overloads and simplified options
- Replace union type with TypeScript function overloads for cleaner IntelliSense
- Simplify TOML options to only include `inlineTables` (most essential option)
- Remove `arraysMultiline` and `indent` options for consistent formatting
- Update memory management to use ArenaAllocator for better cleanup
- Update test snapshots to match new array formatting (no multiline for <4 elements)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-28 11:24:05 +00:00
Meghan Denny
40a795daf8 node: some builtins cleanup (#22200)
Co-authored-by: Meghan Denny <meghan@bun.com>
2025-08-28 11:24:05 +00:00
Meghan Denny
10ccb880a4 node: fix test-http-set-max-idle-http-parser.js (#22179)
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 11:24:05 +00:00
pfg
84604888e9 Private fields (#22189)
ZLS was tested manually and works with private fields (after restarting)

Zig diff:
d1a4e0b0dd..ebe0cdac31

ZLS diff:
15730e8e5d..3733f39c8d

Increases `zig build check` time by maybe 10ms?

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 04:24:04 -07:00
Meghan Denny
4e2e517164 node:http: split up prototype assignment of Server and ServerResponse (#22195)
pulled out of https://github.com/oven-sh/bun/pull/21809

---------

Co-authored-by: Meghan Denny <meghan@bun.com>
2025-08-28 11:24:04 +00:00
Meghan Denny
d355895e63 js: add llhttp to process.versions (#22176)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 11:24:04 +00:00
Meghan Denny
6cc83cde47 bun-types: define process.binding(http_parser) (#22175)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 11:24:04 +00:00
robobun
c04ad1e5db Fix argv handling for standalone binaries - remove extra executable name (#22157) (#22169)
## Summary

Fixes an issue where compiled standalone binaries included an extra
executable name argument in `process.argv`, breaking code that uses
`node:util.parseArgs()` with `process.argv.slice(2)`.

## Problem

When running a compiled binary, `process.argv` incorrectly included the
executable name as a third argument:

```bash
./my-app
# process.argv = ["bun", "/$bunfs/root/my-app", "./my-app"]  # BUG
```

This caused `parseArgs()` to fail with "Unexpected argument" errors,
breaking previously valid code.

## Solution

Fixed the `offset_for_passthrough` calculation in `cli.zig` to always
skip the executable name for standalone binaries, ensuring
`process.argv` only contains the runtime name and script path:

```bash  
./my-app
# process.argv = ["bun", "/$bunfs/root/my-app"]  # FIXED
```

## Test plan

- [x] Added regression test in `test/regression/issue/22157.test.ts`
- [x] Verified existing exec-argv functionality still works correctly  
- [x] Manual testing confirms the fix resolves the parseArgs issue

Fixes #22157

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Michael H <git@riskymh.dev>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-28 11:24:04 +00:00
autofix-ci[bot]
cbb177129d [autofix.ci] apply automated fixes 2025-08-28 11:03:44 +00:00
Claude Bot
830b7ae66f Add JSON.stringify API compatibility to Bun.TOML.stringify
Support both JSON.stringify-style and object-style parameters:

JSON.stringify-style:
- Bun.TOML.stringify(obj, null, 2)        // number for spaces
- Bun.TOML.stringify(obj, null, '\t')     // string for indentation

Object-style (advanced options):
- Bun.TOML.stringify(obj, null, { inlineTables: true })

Updated TypeScript definitions to reflect the enhanced API with
proper union types and comprehensive examples.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-28 11:01:21 +00:00
Claude Bot
0cd5ce2ac0 Implement Bun.TOML.stringify API
Major features implemented:
- Core TOML stringify functionality with comprehensive error handling
- Support for all basic TOML types: strings, numbers, booleans, arrays, tables
- Options support: inlineTables, arraysMultiline, indent
- Proper string escaping with control character handling
- Special float value support (nan, inf, -inf)
- Key validation and quoting when necessary
- Table and inline table formatting
- TypeScript type definitions with comprehensive documentation
- Comprehensive test suite covering basic and advanced functionality

API Features:
- Bun.TOML.stringify(value, replacer?, options?)
- Options: inlineTables, arraysMultiline, indent
- Error messages for different failure modes
- Round-trip compatibility with Bun.TOML.parse()

The implementation provides a solid foundation for TOML stringification
in Bun, following similar patterns to JSON.stringify and YAML.stringify.
Memory management has been carefully handled to prevent use-after-free
issues in the JavaScript runtime.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-28 10:51:20 +00:00
Meghan Denny
6286824e28 node: some builtins cleanup (#22200)
Co-authored-by: Meghan Denny <meghan@bun.com>
2025-08-27 20:34:37 -07:00
Meghan Denny
dcb51bda60 node: fix test-http-set-max-idle-http-parser.js (#22179)
Co-authored-by: Meghan Denny <meghan@bun.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 19:35:30 -07:00
Meghan Denny
36e2870fc8 node:http: split up prototype assignment of Server and ServerResponse (#22195)
pulled out of https://github.com/oven-sh/bun/pull/21809

---------

Co-authored-by: Meghan Denny <meghan@bun.com>
2025-08-27 18:25:50 -07:00
Meghan Denny
5ac0a9a95c js: add llhttp to process.versions (#22176)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 16:50:38 -07:00
Meghan Denny
448fad8213 bun-types: define process.binding(http_parser) (#22175)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 16:50:27 -07:00
robobun
0315c97e7b Fix argv handling for standalone binaries - remove extra executable name (#22157) (#22169)
## Summary

Fixes an issue where compiled standalone binaries included an extra
executable name argument in `process.argv`, breaking code that uses
`node:util.parseArgs()` with `process.argv.slice(2)`.

## Problem

When running a compiled binary, `process.argv` incorrectly included the
executable name as a third argument:

```bash
./my-app
# process.argv = ["bun", "/$bunfs/root/my-app", "./my-app"]  # BUG
```

This caused `parseArgs()` to fail with "Unexpected argument" errors,
breaking previously valid code.

## Solution

Fixed the `offset_for_passthrough` calculation in `cli.zig` to always
skip the executable name for standalone binaries, ensuring
`process.argv` only contains the runtime name and script path:

```bash  
./my-app
# process.argv = ["bun", "/$bunfs/root/my-app"]  # FIXED
```

## Test plan

- [x] Added regression test in `test/regression/issue/22157.test.ts`
- [x] Verified existing exec-argv functionality still works correctly  
- [x] Manual testing confirms the fix resolves the parseArgs issue

Fixes #22157

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Michael H <git@riskymh.dev>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 15:31:28 -07:00
Lydia Hallie
3545cca8cc guides: add Railway deploy guide (#22191)
This PR adds a guide for deploying Bun apps on Railway with PostgreSQL
(optional), including both CLI and dashboard methods, and deploy
template

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 15:08:38 -07:00
Jarred Sumner
b199333f17 Delete test-worker-memory.js 2025-08-27 15:06:26 -07:00
Jarred Sumner
c0ba7e9e34 Unskip some tests (#22116)
### What does this PR do?

### How did you verify your code works?

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-27 06:39:11 -07:00
Jarred Sumner
d4e614da8e deflake 2025-08-27 00:13:45 -07:00
Jarred Sumner
b96980a95d Update node-http2.test.js 2025-08-26 23:42:07 -07:00
Alistair Smith
1dd5761daa fix: move duplication into map itself, since it also frees (#22166)
### What does this PR do?

### How did you verify your code works?

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
2025-08-26 19:45:57 -07:00
Ciro Spaciari
196182f8ec fix(Bun.SQL) fix MySQL by not converting tinyint to bool (#22159)
### What does this PR do?
Change tinyint/bool type from mysql to number instead of bool to match
mariadb and mysql2 behavior since tinyint/bool can be bigger than 1 in
mysql
Fixes https://github.com/oven-sh/bun/issues/22158
### How did you verify your code works?
Test

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 17:58:08 -07:00
Jarred Sumner
a3fcfd3963 Bump WebKit (#22145)
### What does this PR do?

### How did you verify your code works?

---------

Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 17:38:15 -07:00
Alistair Smith
54b90213eb fix: support virtual entrypoints in onResolve() (#22144)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 16:51:41 -07:00
Alistair Smith
fd69af7356 Avoid global React namespace in experimental.d.ts
Co-authored-by: Parbez <imranbarbhuiya.fsd@gmail.com>
2025-08-26 15:15:48 -07:00
SUZUKI Sosuke
3ed06e3ddf Update build JSC script in CONTRIBUTING.md (#22162)
### What does this PR do?

Updates build instructions in `CONTRIBUTING.md`

### How did you verify your code works?

N/A

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 15:15:31 -07:00
taylor.fish
437e15bae5 Replace catch bun.outOfMemory() with safer alternatives (#22141)
Replace `catch bun.outOfMemory()`, which can accidentally catch
non-OOM-related errors, with either `bun.handleOom` or a manual `catch
|err| switch (err)`.

(For internal tracking: fixes STAB-1070)

---------

Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-08-26 12:50:25 -07:00
Alistair Smith
300f486125 Bundler changes to bring us closer to esbuild's api (#22076)
### What does this PR do?

- Implements .onEnd

Fixes #22061

Once #22144 is merged, this also fixes:
Fixes #9862
Fixes #20806

### How did you verify your code works?

Tests

---

TODO in a followup (#22144)
> ~~Make all entrypoints be called in onResolve~~
> ~~Fixes # 9862~~
> ~~Fixes # 20806~~

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-26 01:50:32 -07:00