Commit Graph

13262 Commits

Author SHA1 Message Date
autofix-ci[bot]
ff58806de5 [autofix.ci] apply automated fixes 2025-08-18 20:51:50 +00:00
Zack Radisic
1bdf3f119d disable test on windows due to rename not having posix semantics 2025-08-18 13:49:30 -07:00
Claude Bot
51088d9f4a Fix banned word usage and Windows test failure
- Replace std.StringArrayHashMapUnmanaged with bun.StringArrayHashMapUnmanaged for better performance
- Fix Windows EPERM error in vim-file-swap test by using fs.renameSync instead of fs.cpSync

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-16 03:05:33 +00:00
Claude Bot
e610061a58 Fix compile errors in devserver memory cost calculation
- Remove duplicate deleted_entrypoints field in VoidFieldTypes struct
- Make DeletedEntrypointWatchlist.Entry public for external access
- Fix SmallList API usage: replace .items with .slice() method
- Add memoryCostSmallList helper function for SmallList memory calculation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-16 01:54:56 +00:00
Zack Radisic
f5662a759d Merge branch 'zack/devserver-fix-watching-entrypoint' of github.com:oven-sh/bun into zack/devserver-fix-watching-entrypoint 2025-08-15 18:18:55 -07:00
Zack Radisic
c796200032 update 2025-08-15 18:17:54 -07:00
Zack Radisic
95fb5a6701 refactor 2025-08-15 18:17:30 -07:00
autofix-ci[bot]
2760f020d7 [autofix.ci] apply automated fixes 2025-08-15 03:34:26 +00:00
Claude Bot
465c2532d9 Fix missing deleted_entrypoints field in VoidFieldTypes
- Add deleted_entrypoints field to VoidFieldTypes initialization in memory_cost.zig
- Handle macOS-specific GuardedValue memory cost calculation for DeletedEntrypointWatchlist
- Make DeletedEntrypointWatchlist.Entry public to allow @sizeOf access from memory_cost.zig

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-15 03:32:24 +00:00
Zack Radisic
bf1a5d5100 Merge branch 'zack/devserver-fix-watching-entrypoint' of github.com:oven-sh/bun into zack/devserver-fix-watching-entrypoint 2025-08-14 19:24:19 -07:00
Zack Radisic
2835cccd31 use open instead of stat 2025-08-14 19:23:50 -07:00
autofix-ci[bot]
408e60a324 [autofix.ci] apply automated fixes 2025-08-15 00:49:59 +00:00
Zack Radisic
880fe5cf90 fix crash when html entrypoint is deleted 2025-08-14 17:24:06 -07:00
Zack Radisic
c809e0b557 Fix entrypoing watching on macos 2025-08-14 15:13:44 -07:00
Zack Radisic
53dd3a2c9c wip 2025-08-14 13:08:44 -07:00
Zack Radisic
84f756831d Merge branch 'main' into zack/devserver-fix-watching-entrypoint 2025-08-13 17:34:24 -07:00
Alistair Smith
c106820a57 fix: Use the correct default lib path in bun-types integration test (#21825) 2025-08-13 13:34:15 -07:00
taylor.fish
a4555ee3df Add owned pointer types (#21776)
Add an owned pointer type—a wrapper around a pointer and an allocator.

`Owned(*Foo)` and `Owned([]Foo)` contain both the pointer/slice and the
allocator that was used to allocate it. Calling `deinit` on these types
first calls `Foo.deinit` and then frees the memory. This makes it easier
to remember to free the memory, and hard to accidentally free it with
the wrong allocator.

Optional pointers are also supported (`Owned(?*Foo)`, `Owned(?[]Foo)`),
and an unmanaged variant which doesn't store the allocator
(`Owned(*Foo).Unmanaged`) is available for cases where space efficiency
is a concern.

A `MaybeOwned` type is also provided for representing data that could be
owned or borrowed. If the data is owned, `MaybeOwned.deinit` works like
`Owned.deinit`; otherwise, it's a no-op.

(For internal tracking: fixes STAB-920, STAB-921)
2025-08-12 22:25:49 -07:00
taylor.fish
8d40ee17ed Add thread safety checks to MimallocArena (#21806)
Make sure allocations happen on the same thread.

(For internal tracking: fixes STAB-919)
2025-08-12 22:25:04 -07:00
robobun
d9742eece7 Optimize --lockfile-only to skip tarball downloads (#21768)
## Summary

Optimizes the `--lockfile-only` flag to skip downloading **npm package
tarballs** since they're not needed for lockfile generation. This saves
bandwidth and improves performance for lockfile-only operations while
preserving accuracy for non-npm dependencies.

## Changes

- **Add `prefetch_resolved_tarballs` flag** to
`PackageManagerOptions.Do` struct (defaults to `true`)
- **Set flag to `false`** when `--lockfile-only` is used
- **Skip tarball downloads for npm packages only** when flag is
disabled:
- `getOrPutResolvedPackageWithFindResult` - Main npm package resolution
(uses `Task.Id.forNPMPackage`)
- `enqueuePackageForDownload` - NPM package downloads (uses
`bun.Semver.Version`)
- **Preserve tarball downloads for non-npm dependencies** to maintain
lockfile accuracy:
  - Remote tarball URLs (needed for lockfile generation)
  - GitHub dependencies (needed for lockfile generation)  
  - Generic tarball downloads (may be remote)
  - Patch-related downloads (needed for patch application)
- **Add comprehensive test** that verifies only package manifests are
fetched for npm packages with `--lockfile-only`

## Rationale

Only npm registry packages can safely skip tarball downloads during
lockfile generation because:

 **NPM packages**: Metadata is available from registry manifests,
tarball not needed for lockfile
 **Remote URLs**: Need tarball content to determine package metadata
and generate accurate lockfile
 **GitHub deps**: Need tarball content to extract package.json and
determine dependencies
 **Tarball URIs**: Need content to determine package structure and
dependencies

This selective approach maximizes bandwidth savings while ensuring
lockfile accuracy.

## Test Plan

-  New test in `test/cli/install/lockfile-only.test.ts` verifies only
npm manifest URLs are requested
-  Uses absolute package versions to ensure the npm resolution code
path is hit
-  Test output normalized to work with both debug and non-debug builds
-  All existing install/update tests still pass (including remote
dependency tests)

## Performance Impact

For `--lockfile-only` operations with npm packages, this eliminates
unnecessary tarball downloads, reducing:
- **Network bandwidth usage** (manifests only, not tarballs)
- **Installation time** (no tarball extraction/processing)
- **Cache storage requirements** (tarballs not cached)

The optimization only affects npm packages in `--lockfile-only` mode and
has zero impact on:
- Regular installs (npm packages still download tarballs)
- Remote dependencies (always download tarballs for accuracy)
- GitHub dependencies (always download tarballs for accuracy)

## Files Changed

- `src/install/PackageManager/PackageManagerOptions.zig` - Add flag and
configure for lockfile-only
- `src/install/PackageManager/PackageManagerEnqueue.zig` - Skip npm
tarball generation selectively
- `test/cli/install/lockfile-only.test.ts` - Test with dummy registry

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Alistair Smith <hi@alistair.sh>
2025-08-12 22:19:10 -07:00
Kai Tamkun
37a207e2a4 NAPI fixes (#21775)
### What does this PR do?

Defers exceptions thrown by NAPI code until execution returns/flows to
JS code.

### How did you verify your code works?

Ran existing NAPI tests and added to napi.test.ts.
2025-08-12 19:59:34 -07:00
Michael H
3cf6da9c9b implement bunx --package (#21517)
### What does this PR do?

fixes #7034

### How did you verify your code works?

made tests, but need to do some more manual with release build
2025-08-12 17:07:46 -07:00
taylor.fish
0c83ff3f7e Fix z_allocator implementation when use_mimalloc is false; make Bun compile with use_mimalloc false (#21771)
We can't use `std.heap.c_allocator` as `z_allocator`; it doesn't
zero-initialize the memory. This PR adds a fallback implementation.

This PR also makes Bun compile successfully with `use_mimalloc` set to
false. More work is likely necessary to make it function correctly in
this case, but it should at least compile.

(For internal tracking: fixes STAB-978, STAB-979)
2025-08-11 20:20:58 -07:00
taylor.fish
41b1efe12c Rename disabled parameter in Output.scoped (#21769)
It's very confusing.

(For internal tracking: fixes STAB-977)
2025-08-11 20:19:34 -07:00
Jarred Sumner
4751f12678 Delete this line 2025-08-11 18:42:55 -07:00
Jarred Sumner
98524943f1 Fixes #21779 2025-08-11 18:42:33 -07:00
Jarred Sumner
b6b3dc7eb5 Update docs.yml 2025-08-11 17:04:30 -07:00
Michael H
020fe12887 bun.lock migration: fix packages with long version string (#21753)
### What does this PR do?

cases like `@prisma/engines-version` with version of
`6.14.0-17.fba13060ef3cfbe5e95af3aaba61eabf2b8a8a20` was having issues
with the version and using a "corrupted" string instead

### How did you verify your code works?

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-11 16:26:03 -07:00
Alistair Smith
8e6184707d fix #21766 (#21767)
### What does this PR do?

### How did you verify your code works?
2025-08-11 14:22:49 -07:00
taylor.fish
a57dee5721 Various safety improvements (safety.ThreadLock, stack traces, MimallocArena, RefCount, safety.alloc) (#21726)
* Move `DebugThreadLock` to `bun.safety`
* Enable in `ci_assert` builds, but store stack traces only in debug
builds
  * Reduce size of struct by making optional field non-optional
* Add `initLockedIfNonComptime` as a workaround for not being able to
call `initLocked` in comptime contexts
* Add `lockOrAssert` method to acquire the lock if unlocked, or else
assert that the current thread acquired the lock
* Add stack traces to `CriticalSection` and `AllocPtr` in debug builds
* Make `MimallocArena.init` infallible
* Make `MimallocArena.heap` non-nullable
* Rename `RefCount.active_counts` to `raw_count` and provide read-only
`get` method
* Add `bun.safety.alloc.assertEq` to assert that two allocators are
equal (avoiding comparison of undefined `ptr`s)

(For internal tracking: fixes STAB-917, STAB-918, STAB-962, STAB-963,
STAB-964, STAB-965)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-11 13:40:07 -07:00
taylor.fish
e4beddb839 Reduce false negatives in ban-words.test.ts for undefined struct fields (#21748)
`ban-words.test.ts` attempts to detect places where a struct field is
given a default value of `undefined`, but it fails to detect cases like
the following:

```zig
foo: *Foo align(1) = undefined,
bar: [16 * 64]Bar = undefined,
baz: Baz(u8, true) = undefined,
```

This PR updates the check to detect more occurrences, while still
avoiding (as far as I can tell) the inclusion of any false positives.

(For internal tracking: fixes STAB-971)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-11 13:32:05 -07:00
taylor.fish
dd427a1c61 Improve deepClone methods (#21747)
Various types have a `deepClone` method, but there are two different
signatures in use. Some types, like those in the `css` directory, have
an infallible `deepClone` method that cannot return an error. Others,
like those in `ast`, are fallible and can return `error.OutOfMemory`.

Historically, `BabyList.deepClone` has only worked with the fallible
kind of `deepClone`, necessitating the addition of
`BabyList.deepClone2`, which only works with the *in*fallible kind.

This PR:

* Updates `BabyList.deepClone` so that it works with both kinds of
method
* Updates `BabyList.deepClone2` so that it works with both kinds of
method
* Renames `BabyList.deepClone2` to `BabyList.deepCloneInfallible`
* Adds `bun.handleOom(...)`, which is like `... catch bun.outOfMemory()`
but it can't accidentally catch non-OOM-related errors
* Replaces an occurrence of `anyerror` with a more specific error set

(For internal tracking: fixes STAB-969, STAB-970)

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-11 13:29:53 -07:00
Michael H
0b7a6024e0 vscode extention: fix oom with test explorer from too many files (#21744)
### What does this PR do?

Limit to only 5k test files for initial scan + ignore node_modules for
subdirs.

### How did you verify your code works?

manual
2025-08-10 21:36:04 -07:00
robobun
35027a1399 Add GitHub metrics collection script (#21750) 2025-08-10 20:22:08 -07:00
robobun
cf8d3183b3 Bump LATEST file to 1.2.20 (#21749) 2025-08-10 20:19:25 -07:00
Meghan Denny
45ed0cb08e Bump 2025-08-10 11:38:31 -07:00
Jarred Sumner
6ad208bc32 Fix integer cast truncation panic on Windows for buffers > 4GB (#21738)
## Summary
This PR fixes a panic that occurs when file operations use buffers
larger than 4GB on Windows.

## The Problem
When calling `fs.readSync()` or `fs.writeSync()` with buffers larger
than 4,294,967,295 bytes (u32::MAX), Bun panics with:
```
panic(main thread): integer cast truncated bits
```

## Root Cause
The Windows APIs `ReadFile()` and `WriteFile()` expect a `DWORD` (u32)
for the buffer length parameter. The code was using `@intCast` to
convert from `usize` to `u32`, which panics when the value exceeds
u32::MAX.

## The Fix
Changed `@intCast` to `@truncate` in four locations:
1. `sys.zig:1839` - ReadFile buffer length parameter
2. `sys.zig:1556` - WriteFile buffer length parameter  
3. `bun.zig:230` - platformIOVecCreate length field
4. `bun.zig:240` - platformIOVecConstCreate length field

With these changes, operations with buffers > 4GB will read/write up to
4GB at a time instead of panicking.

## Test Plan
```js
// This previously caused a panic on Windows
const fs = require('fs');
const fd = fs.openSync('test.txt', 'r');
const buffer = Buffer.allocUnsafe(4_294_967_296); // 4GB + 1 byte
fs.readSync(fd, buffer, 0, buffer.length, 0);
```

Fixes https://github.com/oven-sh/bun/issues/21699

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Jarred Sumner <jarred@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
bun-v1.2.20
2025-08-10 04:01:35 -07:00
Jarred Sumner
b0799da968 Harden Transfer-Encoding (#21737)
### What does this PR do?

### How did you verify your code works?

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-10 03:52:40 -07:00
Jarred Sumner
a67ba81e0b Only highlight per chunk instead of per line (#21729) 2025-08-09 21:35:17 -07:00
Jarred Sumner
7cdc5d879c Don't highlight backgrounds when it's just words that changed (#21727)
### What does this PR do?

Setting the background color on plaintext diffs makes the plaintext
harder to read. This is particularly true when the input is longer.

This conservatively makes us only add the background color to the diff
when the characters being highlighted are all whitespaces, punctuation
or non-printable.

This branch:

<img width="748" height="388" alt="image"
src="https://github.com/user-attachments/assets/ceaf02ba-bf71-4207-a319-c041c8a887de"
/>

Canary:

<img width="742" height="404" alt="image"
src="https://github.com/user-attachments/assets/cc380f45-5540-48ed-aea1-07f4b0ab291e"
/>


### How did you verify your code works?

Updated test
2025-08-09 19:50:25 -07:00
Jarred Sumner
1dc9fdfd9b Fix process.stdout/stderr missing Symbol.asyncIterator (#21720)
## Summary
- Adds `Symbol.asyncIterator` to `process.stdout` and `process.stderr`
when they are TTY or pipe/socket streams
- Matches Node.js behavior where these streams are Duplex-like and
support async iteration
- Does not add the iterator when streams are redirected to files
(matching Node.js SyncWriteStream behavior)

## Test plan
- Added test in
`test/regression/issue/test-process-stdout-async-iterator.test.ts`
- Verified the fix works with Claude Code on Linux x64
- Test passes with `bun bd test
test/regression/issue/test-process-stdout-async-iterator.test.ts`

Fixes #21704

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-09 06:40:36 -07:00
robobun
584946b0ce Fix comma operator optimization to preserve 'this' binding semantics (#21653)
## Summary
- Fix transpiler bug where comma expressions like `(0, obj.method)()`
were incorrectly optimized to `obj.method()`
- This preserved the `this` binding instead of stripping it as per
JavaScript semantics
- Add comprehensive regression test to prevent future issues

## Root Cause
The comma operator optimization in `src/js_parser.zig:7281` was directly
returning the right operand when the left operand had no side effects,
without checking if the expression was being used as a call target.

## Solution
- Added the same `is_call_target` check that other operators (nullish
coalescing, logical OR/AND) use
- When a comma expression is used as a call target AND the right operand
has a value for `this`, preserve the comma expression to strip the
`this` binding
- Follows existing patterns in the codebase for consistent behavior

## Test Plan
- [x] Reproduce the original bug: `(0, obj.method)()` incorrectly
preserved `this`
- [x] Verify fix: comma expressions now correctly strip `this` binding
in function calls
- [x] All existing transpiler tests continue to pass
- [x] Added regression test covering various comma expression scenarios
- [x] Tested edge cases: nested comma expressions, side effects,
different operand types

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-09 05:11:50 -07:00
robobun
3766f183e6 deps: bump WebKit to eb92990ae9e0a8df3141b8cf946a4f250393e213 (#21702)
## Summary
- Updates WebKit from 75f6499 to eb92990 (latest release from
oven-sh/webkit)
- This brings in the latest WebKit improvements and fixes

## Test plan
- [ ] Verify the build completes successfully
- [ ] Run existing test suite to ensure no regressions

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-09 05:00:46 -07:00
Jarred Sumner
19fac68e81 Reduce stack space usage of parseSuffix (#21662)
### What does this PR do?

Reduce stack space usage of parseSuffix

### How did you verify your code works?

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-09 00:20:17 -07:00
Meghan Denny
2f84949fe0 ci: do not retry error conditions that are always failure (#21716) 2025-08-08 23:25:52 -07:00
Jarred Sumner
964d4dac2c Rewrite AbortSignal.timeout (#21695)
### What does this PR do?

On Linux, AbortSignal.timeout created a file descriptor for each timeout
and did not keep the event loop alive when a timer was active. This is
fixed.

### How did you verify your code works?

Fewer flaky tests

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Claude <claude@anthropic.ai>
2025-08-08 23:07:19 -07:00
Meghan Denny
a9d62d58ea Revert "ci: lower windows test agent from c7i.2xlarge to c7i.xlarge (#21707)" (#21717) 2025-08-08 22:45:26 -07:00
robobun
0827add9a3 ci: optimize clang-format in GitHub Actions (#21715)
## Summary
- Replace cmake-based clang-format with dedicated bash script that
directly processes source files
- Optimize CI to only install clang-format-19 instead of entire LLVM
toolchain
- Script enforces specific clang-format version with no fallbacks

## Changes
1. **New bash script** (`scripts/run-clang-format.sh`):
   - Directly reads C++ files from `CxxSources.txt`
   - Finds all header files in `src/` and `packages/` directories
   - Respects existing `.clang-format` configuration files
   - Requires specific clang-format version (no fallbacks)
   - Defaults to format mode (modifies files in place)

2. **Optimized GitHub Action**:
- Only installs `clang-format-19` package with `--no-install-recommends`
   - Avoids installing unnecessary components like manpages
   - Uses new bash script instead of cmake targets

3. **Updated package.json scripts**:
- `clang-format`, `clang-format:check`, and `clang-format:diff` now use
the bash script

## Test plan
- [x] Verified script finds and processes all C++ source and header
files
- [x] Tested formatting works correctly by adding formatting issues and
running the script
- [x] Confirmed script respects `.clang-format` configuration files
- [x] Script correctly requires specific clang-format version

🤖 Generated with [Claude Code](https://claude.ai/code)

---------

Co-authored-by: Claude <claude@anthropic.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-08 22:36:49 -07:00
Meghan Denny
05cff5cfde test: fix static-initializers.test.ts
regressed in 46e1c5a0fa
2025-08-08 22:28:42 -07:00
Meghan Denny
f5c138d646 ci: lower build-cpp agent from 16xlarge to 4xlarge (#21711)
this instance type was reported to be our 1st most expensive per aws
bill

as long as it finishes before build-zig it doesnt affect the total run
time

----

<img width="1512" height="165" alt="image"
src="https://github.com/user-attachments/assets/8581f0d6-348c-4be8-98e2-bff8f659b26f"
/>

<img width="1512" height="163" alt="image"
src="https://github.com/user-attachments/assets/cefd5a50-26b2-4dfb-8592-f723874bc461"
/>

<img width="1512" height="164" alt="image"
src="https://github.com/user-attachments/assets/7234cc28-2f7d-4ffa-97c1-67106749dd4e"
/>
2025-08-08 18:52:21 -07:00