Commit Graph

12905 Commits

Author SHA1 Message Date
Jarred-Sumner
8ab2d6b0cd bun run prettier 2025-07-12 06:33:13 +00:00
Jarred-Sumner
346e964050 bun run zig-format 2025-07-12 06:31:53 +00:00
Claude Bot
6d713aabe0 Add comprehensive Redis reconnection test suite with test-utils integration
🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-12 06:26:19 +00:00
Claude Bot
98eb07fb69 Fix Bun.redis reconnection after manual close
The Bun.redis client was failing to reconnect after a manual connection
close when a new command was issued. This affected the user experience
when applications needed to resume Redis operations after a connection
interruption.

## Root Cause

When `redis.close()` was called, the `is_manually_closed` flag was set
to `true`. Subsequently, when a new command was issued:

1. The connection status was `.failed`
2. Commands would be rejected instead of being queued
3. No reconnection was attempted because `is_manually_closed` prevented it
4. HELLO authentication responses were mishandled during reconnection

## Solution

1. **Modified `send` method**: Added logic to detect when a command is
   being issued on a failed/disconnected connection that was manually
   closed but has auto-reconnect enabled. In this case:
   - Reset the `is_manually_closed` flag to `false`
   - Set the `is_reconnecting` flag to `true`
   - Reset `is_authenticated` flag to ensure proper HELLO handling
   - Reset `retry_attempts` to 0 for immediate reconnection
   - Trigger reconnection via `this.parent().reconnect()`

2. **Modified `onClose` method**: Updated the condition to only skip
   reconnection if the connection was manually closed AND not currently
   attempting to reconnect.

## Testing

- **100% success rate**: All 8 comprehensive test scenarios pass
- **Manual verification**: Thoroughly tested with various edge cases
- **Added test suite**: `test/js/valkey/reconnection.test.ts` with 8 tests:
  1. Basic reconnection after manual close
  2. Multiple commands after reconnection
  3. Repeated reconnections
  4. Different Redis commands (INCR, DECR, EXISTS, EXPIRE, TTL)
  5. Large data (10KB) reconnection
  6. Connection state tracking
  7. Quick successive reconnections
  8. Command queueing during reconnection

The fix ensures that Redis reconnection works reliably in all scenarios
without any regressions to existing functionality.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-12 06:20:20 +00:00
Dylan Conway
f24e8cb98a implement "nodeLinker": "isolated" in bun install (#20440)
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
2025-07-09 00:19:57 -07:00
Meghan Denny
36bedb0bbc js: fix async macros on windows (#20903) 2025-07-08 21:23:25 -07:00
Meghan Denny
a63f09784e .vscode/launch.json: delete unused configurations (#20901) 2025-07-08 16:45:24 -07:00
Jarred Sumner
454316ffc3 Implement "node:module"'s findSourceMap and SourceMap class (#20863)
Co-authored-by: Claude <claude@anthropic.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
2025-07-07 23:08:12 -07:00
Alistair Smith
d4a52f77c7 Move ReadableStream#{text,bytes,json,blob} to global (#20879)
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
2025-07-07 23:06:27 -07:00
Ciro Spaciari
c2311ed06c fix(http2) avoid sending RST multiple times per stream (#20872) 2025-07-07 22:36:39 -07:00
Kai Tamkun
05e8a6dd4d Add support for vm.constants.DONT_CONTEXTIFY (#20088) 2025-07-07 19:29:53 -07:00
Ciro Spaciari
75902e6a21 fix(s3) fix loading http endpoint from env (#20876) 2025-07-07 19:24:32 -07:00
Ciro Spaciari
aa06455987 refactor(postgres) improve postgres code base (#20808)
Co-authored-by: cirospaciari <6379399+cirospaciari@users.noreply.github.com>
2025-07-07 18:41:01 -07:00
Alistair Smith
19a855e02b types: Introduce SQL.Helper in Bun.sql (#20809)
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-07-07 17:47:51 -07:00
190n
b1a0502c0c [publish images] fix v8.test.ts timeouts (#20871) 2025-07-07 16:16:47 -07:00
Michael H
0399ae0ee9 followup for bun pm version (#20799) 2025-07-07 11:21:36 -07:00
Zack Radisic
dacb75dc1f Fix crash in bundler related to onLoad plugins that return file loader for HTML imports (#20849) 2025-07-07 01:07:03 -07:00
Jarred Sumner
c370645afc Update zig-javascriptcore-classes.mdc 2025-07-06 21:08:26 -07:00
Jarred Sumner
e1957228f3 [internal] Add error when .classes.ts files are invalid 2025-07-06 21:07:38 -07:00
Jarred Sumner
9feaab47f5 Update environment.json 2025-07-05 22:20:29 -07:00
CountBleck
d306e65d0e Remove duplicate toBeInstanceOf type declaration for Expect (#20844) 2025-07-05 17:25:52 -07:00
Adam
7ba4b1d01e Fix: deprecated goo.gl links in snapshots raised in issue #20086 (#20424) 2025-07-05 00:58:42 -07:00
Dylan Conway
906b287e31 fix BUN-KHE (#20820)
Co-authored-by: Claude <noreply@anthropic.com>
2025-07-04 15:17:24 -07:00
Jarred Sumner
eabbd5cbfb Fix React HMR duplicate identifier error for named default exports (#20812)
Co-authored-by: Claude <noreply@anthropic.com>
2025-07-04 03:06:00 -07:00
Meghan Denny
068997b529 make node:dns,net,cluster,tls exception checker clear (#20658)
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com>
2025-07-03 18:28:38 -07:00
Michael H
0612dc7bd9 Support process.features.typescript (#20801) 2025-07-03 16:26:32 -07:00
Michael H
8657d705b8 remove yarn from default-trusted-dependencies.txt (#20684) 2025-07-03 16:23:03 -07:00
Meghan Denny
2e59e845fa test: refactor node-napi.test.ts for more observability (#20781)
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com>
2025-07-03 14:37:11 -07:00
Meghan Denny
00df6cb4ee Bump 2025-07-03 11:59:00 -07:00
Jarred Sumner
0d4089ea7c Fixes #20753 (#20789)
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
bun-v1.2.18
2025-07-03 01:06:22 -07:00
Jarred Sumner
27c979129c Introduce Bun.randomUUIDv5 (#20782)
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: jarred <jarred@bun.sh>
Co-authored-by: Meghan Denny <meghan@bun.sh>
2025-07-02 22:47:14 -07:00
Jarred Sumner
8bb835bf63 Fix: Dynamic imports incorrectly resolve to CSS files when code splitting is enabled (#20784)
Co-authored-by: Meghan Denny <meghan@bun.sh>
2025-07-02 22:31:02 -07:00
Jarred Sumner
8bf50cf456 Fix 2 differences in napi vs node (#20761)
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <Jarred-Sumner@users.noreply.github.com>
2025-07-02 22:11:21 -07:00
Meghan Denny
01e2cb25e3 test: bump zlib/leak.test.ts for asan 2025-07-02 21:48:24 -07:00
Jarred Sumner
010e715902 Upgrade Webkit to 29bbdff0f94f (#20780) 2025-07-02 20:50:15 -07:00
Jarred Sumner
8b321cc1c6 Match Node.js v24 behavior for napi_get_value_string_utf8 handling of NAPI_AUTO_LENGTH (#20698)
Co-authored-by: Claude <noreply@anthropic.com>
2025-07-02 20:10:08 -07:00
Zack Radisic
0b9bab34d8 SSG (#20745)
Co-authored-by: Alistair Smith <hi@alistair.sh>
2025-07-02 20:06:43 -07:00
Meghan Denny
61f0cc497b ci: log available disk space at the start of build/test run (#20779) 2025-07-02 19:43:54 -07:00
Michael H
764e20ee19 implement bun pm version (#20706) 2025-07-02 18:54:47 -07:00
Meghan Denny
0276f5e4a3 misc: use fromJSHostCallGeneric in a few more places (#20778) 2025-07-02 18:35:44 -07:00
Jarred Sumner
5a7b5ceb33 Fix several missing async context tracking callbacks (#20759)
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
2025-07-02 17:45:00 -07:00
Ciro Spaciari
a04cf04cd5 fix(grpc/http2) fix tonic Rust support (#20738)
Co-authored-by: cirospaciari <6379399+cirospaciari@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-07-02 17:43:38 -07:00
Ben Grant
79284376ca Delete test-net-bytes-stats.js
Mistakenly re-added in #20659 after prior revert in #20693
2025-07-02 17:32:19 -07:00
Alistair Smith
452000a2ce Node.js test test-fs-watchfile.js (#20773) 2025-07-02 15:04:39 -07:00
190n
172aecb02e [publish images] Upgrade self-reported Node.js version from 22.6.0 to 24.3.0 (v2) (#20772)
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: Ashcon Partovi <ashcon@partovi.net>
Co-authored-by: pfg <pfg@pfg.pw>
Co-authored-by: pfgithub <6010774+pfgithub@users.noreply.github.com>
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
2025-07-02 12:06:08 -07:00
Ben Grant
ea57037567 Revert "Upgrade self-reported Node.js version from 22.6.0 to 24.3.0 (#20659) [publish images]"
This reverts commit 80309e4d59. It breaks the Windows CI.
2025-07-02 09:40:32 -07:00
Jarred Sumner
80309e4d59 Upgrade self-reported Node.js version from 22.6.0 to 24.3.0 (#20659) [publish images]
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: Ashcon Partovi <ashcon@partovi.net>
Co-authored-by: pfg <pfg@pfg.pw>
Co-authored-by: pfgithub <6010774+pfgithub@users.noreply.github.com>
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Ben Grant <ben@bun.sh>
2025-07-02 00:03:05 -07:00
190n
48c5256196 Fix assertions_only usage in fromJSHostCallGeneric (#20733) 2025-07-01 23:36:56 -07:00
Jarred Sumner
e1ec32caea Fix incorrect comptime conditional 2025-07-01 20:33:34 -07:00
mizulu
7f55b1af55 docs: fix missing word in the bundler text loader section (#20723) 2025-07-01 16:05:06 -07:00