* add: prevent script install to be spawned if bun install is invoked
* add: test for infinite install loop
* add: error message
* fix: error message, exit code, test
---------
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
* node:child_process: allow passing stdin,stdout,stderr to spawn
* this doesnt actually need to be limited to 0,1,2
* Apply formatting changes
* fix stream guards
* undo process internals change
* wrap check in function for better clarity
* lazy load node:fs more
---------
Co-authored-by: nektro <nektro@users.noreply.github.com>
* [bundows] Make bun install 60% faster
* [autofix.ci] apply automated fixes
* Do not keep node_modules folder open between async tasks. Make sure we call runTasks on every event loop wakeup.
* Update install.zig
* Fix deadlock
* Make that deadlock impossible
* a little less repetitive
* Fix test failure with local tarball
* Get those tests to pass
* Normalize absolutely
* lets see how many times we call GetFinalPathNameByHandle
* Workaround https://github.com/ziglang/zig/issues/19586https://github.com/ziglang/zig/issues/19586
* Is the dev-server-100 test failure a hash table collision?
* Give it its own cache dir
* We cannot change the git task ids
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* If any failed to install, always exit with non-zero
* [autofix.ci] apply automated fixes
* This test should fail
* Update bun-link.test.ts
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* these comments were redundant
* better windows support here
* slightly better error message
* didnt realize this variable already existed
* fix node-gyp shim script
* move 'windows bin linking shim should work' to its own file
* run all lifecycle scripts on windows with bun shell
* tidy
* clean imports
* this seemed missing
* remove these comments
* fix the shim again
* fix posix release ensureTempNodeGypScript
* revert this change, it was correct before
* root scripts in foreground
* ignore if silent
* test for breaking changes
* move back to installPackages
* [autofix.ci] apply automated fixes
* boolean variable, comptime, 1_1_0
* flip the 1.1 flag
* add for the next batch of breakings
* make it buidl
* enable breaking changes tests
* fix version fmt
* silent node-gyp
* comment change
---------
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
* bun:test: implement test.todoIf and describe.todoIf
* fix bun-install-registry.test.ts and mark some as todo
* add even more tests
* remove todoIf from this file
* [autofix.ci] apply automated fixes
* fix regression
* this extra expect was incorrect
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* remove comment
* fix prompt test
* more time like leaky case
* remove comments
* fixed
---------
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* fix napi tests
* only windows, update passing tests
* remove closing remainder
* fix child_process-node.test.js
* might fail in ci
* oops
* fix dns tests
* remove comment
* sometimes it is slow
* update test
* maybe fix timeout error
* one more try
* off by one, valid npm package name
* update test
* fix hot tests
* revert
* remove close
* Replace some of std.ChildProcess with bun.spawnSync
* Update process.zig
* Fix some build errors
* Fix linux build
* Keep error
* Don't print a mesasge in this case
* Update spawn.test.ts
* Make `bun install` faster on Linux
* Comments + edgecases
* Fix the tests
* Add bun install launch.json
---------
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Zack Radisic <zack@theradisic.com>
* more tests
* update migration.zig
* fix up paths
* update tests
* update tests
* test
* test
* update registry tests
* comments
* early exit if stream is invalid
* dont pass invalid_fd to openFileAtWindows
* fix merge
* misc crash fix
* make this use optional pointers instead of 0xaa
* ensure absolute paths are propagated properly
* package.json expects forward slash
* this assert was invalid
* add panic checks
* pass bun-remove
* more panic checks
* test: pass bun-add
* querying these hangs outside bun too
* fix compile error from merge conflict resolution
* use compileError instead of comptime unreachable
* tidy
* bunx: check for the .exe bin extension
* bunx: another route to make cache path if it doesnt exist
* install: another case of FolderResolution.getOrPut expecting absolute path
* fix a bun install crash
* dont print zig stack trace if bun install fails
* test: pass bun-link
* test: bunx: add more expects
* test: bun-install-registry: pass
* test: bun-install: pass
* test: bun-pm: pass
* fix merge main error
* fix posix tests
* fix last failing test in bun-install.test.ts
symlink difference between platforms
* bun-install-registry.test.ts fix
* bun-run.test.ts: remove stray console log
---------
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: Meghan Denny <hello@nektro.net>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* make sure source data is set too
* make default trusted dependencies work
* undo
* test
---------
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* Use system shell + add to bunfig
* Update CMakeLists.txt
* Fix tests + flags
* Use execPath
* windows
* Propagate exit code
* Add test for default shell in use
* Update bun-run-bunfig.test.ts
* Update bun-run-bunfig.test.ts
---------
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
* fix recursion
* accurate count of blocked package scripts
* update
* fix merge
* reset pipereaders, set bin linker error correctly
* more pretty
* small changes
* e
* update tests
* this one too
* bun.start_time, iterate package_ids, remove put
* WIP sync close (shows ref count bug in stream)
* fix closing on PipeWriter and PipeReader
* remove old todos
* join
* Some shell changes
at least it compiles
* fix some compile errors
* fix ref/unref server on windows
* actually use the ref count in this places
* make windows compile again
* more tests passing
* Make shell compile again
* Slowly remove some `@panic("TODO SHELL")`
* Eliminate `@panic("TODO SHELL")` for BufferedWriter
* Holy cleansing of `@panic("TODO SHELL")`
at least it compiles now
* Okay now the shell compiles, but segfaults
* Fix compiler errors
* more stable stream and now Content-Range pass
* make windows compile again
* revert stuff until the fix is actually ready
* revert onDone thing
* Fix buffered writer for shell
* Fix buffered writer + shell/subproc.zig and windows build
* Fix for #8982 got lost in the merge
* Actually buffer subproc output
* Fix some stuff shell
* oops
* fix context deinit
* fix renderMissing
* shell: Fix array buffer
* more stable streams (#9053)
fix stream ref counting
* wip
* Remove `@panic("TODO")` on shell event loop tasks and Redirect open flags got lost in merge
* Support redirects
* fixes
cc @cirospaciari
* Update ReadableStreamInternals.ts
* Fix spurious error
* Update stream.js
* leak
* Fix UAF
cc @cirospaciari
* Fix memory leaks
* HOLY FUCK big refactor
* misc cleanup
* shell: Fix a bunch of tests
* clean up
* gitignore: fix ending newline
* get windows compiling again
* tidy
* hide linker warn with icu
* closeIfPossible
* Better leak test
* Fix forgetting to decrement reference count
* Update stdio.zig
* Fix shell windows build
* Stupid unreachable
* Woops
* basic echo hi works on windows
* Fix flaky test on Windows
* Fix windows regression in Bun.main (#9156)
* Fix windows regression in Bun.main
* Handle invalid handles
* Fix flaky test
* Better launch config
* Fixup
* Make this test less flaky on Windows
* Fixup
* Cygwin
* Support signal codes in subprocess.kill(), resolve file path
* Treat null as ignore
* Ignore carriage returns
* Fixup
* shell: Fix IOWriter bug
* shell: Use custom `open()`/`openat()`
* windows shell subproc works
* zack commit
* I think I understand WindowsStreamingWriter
* fix thing
* why were we doing this in tests
* shell: Fix rm
* shell: Add rm -rf node_modules/ test
* shell: use `.runAsTest()` in some places to make it easier to determine which test failed
* [autofix.ci] apply automated fixes
* woopsie
* Various changes
* Fix
* shell: abstract output task logic
* shell: mkdir builtin
* fixup
* stuff
* shell: Make writing length of 0 in IOWriter immediately resolve
* shell: Implement `touch`
* shell: basic `cat` working
* Make it compile on windows
* shell: Fix IOReader bug
* [autofix.ci] apply automated fixes
* fix windows kill on subprocess/process
* fix dns tests to match behavior on windows (same as nodejs)
* fix windows ci
* again
* move `close_handle` to flags in `PipeWriter` and fix shell hanging
* Fix `ls` not giving non-zero exit code on error
* Handle edgecase in is_atty
* Fix writer.flush() when there's no data
* Fix some tests
* Disable uv_unref on uv_process_t on Windows, for now.
* fix writer.end
* fix stdout.write
* fix child-process on win32
* Make this test less flaky on Windows
* Add assertion
* Make these the same
* Make it pass on windows
* Don't commit
* Log the test name
* Make this test less flaky on windows
* Make this test less flaky on windows
* Print which test is taking awhile in the runner
* fixups
* Fixups
* Add some assertions
* Bring back test concurrency
* shell: bring back redirect stdin
* make it compile again cc @zackradisic
* initialize env map with capacity
* some fixes
* cleanup
* oops
* fix leak, fix done
* fix unconsumedPromises on events
* always run expect
* Update child_process.test.ts
* fix reading special files
* Fix a test
* Deflake this test
* Make these comparisons easier
* Won't really fix it but slightly cleaner
* Update serve.test.ts
* Make the checks for if the body is already used more resilient
* Move this to the harness
* Make this test not hang in development
* Fix this test
* Make the logs better
* zero init some things
* Make this test better
* Fix readSocket
* Parallelize this test
* Handle EPipe and avoid big data
* This was a mistake
* Fix a bunch of things
* Fix memory leak
* Avoid sigpipe + optimize + delete dead code
* Make this take less time
* Make it bigger
* Remove some redundant code
* Update process.zig
* Merge and hopefully don't breka things along teh way
* Silence build warning
* Uncomment on posix
* Skip test on windows
* windows
* Cleanup test
* Update
* Deflake
* always
* less flaky test
* [autofix.ci] apply automated fixes
* logs
* fix uaf on shell IOReader
* stuff to make it work with mini event loop
* fix 2 double free scenarios, support redirections on windows
* shell: Make `1>&2` and `2>&1` work with libuv
* yoops
* Partial fix
* Partial fix
* fix build
* fix build
* ok
* Make a couple shell tests pass
* More logging
* fix
* fix
* Fix build issue
* more tests pass
* Deflake
* Deflake
* Use Output.panic instead of garbled text
* Formatting
* Introduce `bun.sys.File`, use it for `Output.Source.StreamType`, fix nested Output.scoped() calls, use Win32 `ReadFile` API for reading when it's not a libuv file descriptor.
This lets us avoid the subtle usages of `unreachable` in std.os when writing to stdout/stderr.
Previously, we were initializing the libuv loop immediately at launch due to checking for the existence of a bun build --compile'd executable. When the file descriptor is not from libuv, it's just overhead to use libuv
cc @paperdave, please tell me if Iany of that is incorrect or if you think this is a bad idea.
* Fix closing undefined memory file descriptors in spawn
cc @zackradisic
* pause instead of close
* Fix poorly-written test
* We don't need big numbers for this test
* sad workaround
* fixup
* Clearer error handling for this test
* Fix incorrect test
@electroid when ReadableStream isn't closed, hanging is the correct behavior when consuming buffered data. We cannot know if the buffered data is finished if the stream never closes.
* Fix build
* Remove known failing on windows
* Deflake
* Mark no longer failing
* show all the failing tests
* Sort the list of tests
* fix argument handling
* dont show "posix_spawn" as an error code on windows
* make bun-upgrade.test.ts pass on windows
* fix bunx and bun create again sorry
* a
* fix invalidexe because we should not be running javascript files as if they were exes
* Concurrency in test runner + better logging
* Revert "fix invalidexe because we should not be running javascript files as if they were exes"
This reverts commit da47cf8247.
* WIP: Unix fixes (#9322)
* wip
* [autofix.ci] apply automated fixes
* wip 2
* [autofix.ci] apply automated fixes
---------
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* Update runner.node.mjs
* Update runner.node.mjs
* Document some environment variables
* shell: Make `Response` work with builtins
* Make it compile
* make pwd test pass
* [autofix.ci] apply automated fixes
* Fix printing garbage for source code previews
* Update javascript.zig
* Fix posix test failures
* Fix signal dispatch
cc @paperdave. Signals can be run from any thread. This causes an assertion failure when the receiving thread happens to not be the main thread. Easiest to reproduce on linux when you spawn 100 short-lived processes at once.
* windows
---------
Co-authored-by: cirospaciari <ciro.spaciari@gmail.com>
Co-authored-by: Zack Radisic <56137411+zackradisic@users.noreply.github.com>
Co-authored-by: Zack Radisic <zackradisic@Zacks-MBP-2.attlocal.net>
Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: Zack Radisic <zack@theradisic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: dave caruso <me@paperdave.net>
Co-authored-by: Dylan Conway <dylan.conway567@gmail.com>
* empty trustedDependencies
* tests
* handle edgecases with default trusted dependencies
* could be zero length
* --trusted and skipped scripts
* resolver too
* second run --trusted
* --trust, better formatting
* more tests
* --trusted applies to dep deps, more tests
* progress
* fix build
* fix crash, make it look good, comments
* alphabetize, verbose log
* feature flag
* update lockfile
* update skipped text
* check update requests first
* be more careful with inline strings
* only with scripts
* fix tests, todo tests
* fix another test
* fix merge
* fix fix merge
* check binding.gyp for tarball and git resolutions
* remove dead code
* debug assert
* move newline printing
* use enum for `__has_install_script`
* oops
* clone packages
* Update src/install/install.zig
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
---------
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
* make bun-debug properly override `bun` in path
* windows path
* fix more issues with bunx
* sync
* stuff
* stuff
* f
* stuff
* further work
* a
* [autofix.ci] apply automated fixes
* okay
* fix building on posix systems
* ok
* make it so bun create cant crash + review
* docuemnt why return false is ok
* .
* cache bust
* merge
* yeah
* yea
* Update src/install/install.zig
* review results
* this will probably fix hardlink issue on windwo
* okay
* how did that work before
---------
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* Updated `upgrade` to return error when used with cmd arguments
- Updated `upgrade` command to check for command-line arguments and return an error if so providing a suggested `update` command.
* added test
* updated condition to allow
* Upgrade argument check now only checks if all arguments contain `--`
- Added more tests
* Using `cpSync` in the following context results in an "Is a directory" error
* Update message displayed back to user
Co-authored-by: dave caruso <me@paperdave.net>
* moved args check to upgrade_command.zig
* fixed broken tests
* changing string interpolation to join() for paths
* [autofix.ci] apply automated fixes
* Fixed build errors
- Removed call to `std.mem.span`
- Added conditional to only run if there's more than 2 arguments (ignores the exec and `upgrade`)
- Added new test to ensure `upgrade` runs with 0 arguments passed
---------
Co-authored-by: dave caruso <me@paperdave.net>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
