Commit Graph

14037 Commits

Author SHA1 Message Date
Alistair Smith
fbd58db004 changes 2025-10-03 16:11:37 -07:00
Alistair Smith
81999c26e6 extend the debug timeout a little 2025-10-03 15:05:50 -07:00
Alistair Smith
dde1f9e610 pin peechy 2025-10-03 14:26:50 -07:00
Alistair Smith
c9b5ba1c96 bump builtin react-refresh 2025-10-03 13:17:53 -07:00
Alistair Smith
74f4fcf2a6 Revert launch.json 2025-10-03 12:58:41 -07:00
Alistair Smith
031f12442d fix: We do require react/react-dom 2025-10-03 12:53:48 -07:00
autofix-ci[bot]
a20a718e48 [autofix.ci] apply automated fixes 2025-10-03 18:41:41 +00:00
Alistair Smith
33537b6ec1 Merge branch 'main' into ali/react 2025-10-03 11:38:33 -07:00
Alistair Smith
952436fc4c returnIfException() 2025-10-03 11:36:02 -07:00
Alistair Smith
31352bc646 fix test 2025-10-03 11:36:02 -07:00
Alistair Smith
ff84564c11 fix that 2025-10-03 11:36:02 -07:00
Alistair Smith
cc78a1bca1 fix: re-inject react-refresh in auto mode 2025-10-03 11:36:02 -07:00
robobun
c8cb7713fc Fix Windows crash in process.title when console title is empty (#23184)
## Summary

Fixes a segmentation fault on Windows 11 when accessing `process.title`
in certain scenarios (e.g., when fetching system information or making
Discord webhook requests).

## Root Cause

The crash occurred in libuv's `uv_get_process_title()` at `util.c:413`
in the `strlen()` call. The issue is that `uv__get_process_title()`
could return success (0) but leave `process_title` as NULL in edge cases
where:

1. `GetConsoleTitleW()` returns an empty string
2. `uv__convert_utf16_to_utf8()` succeeds but doesn't allocate memory
for the empty string
3. The subsequent `assert(process_title)` doesn't catch this in release
builds
4. `strlen(process_title)` crashes with a null pointer dereference

## Changes

Added defensive checks in `BunProcess.cpp`:
1. Initialize the title buffer to an empty string before calling
`uv_get_process_title()`
2. Check if the buffer is empty after the call returns
3. Fall back to "bun" if the title is empty or the call fails

## Testing

Added regression test in `test/regression/issue/23183.test.ts` that
verifies:
- `process.title` doesn't crash when accessed
- Returns a valid string (either the console title or "bun")

Fixes #23183

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
2025-10-03 02:54:23 -07:00
Dylan Conway
666180d7fc fix(install): isolated install with file dependency resolving to root package (#23204)
### What does this PR do?
Fixes `file:.` in root package.json or `file:../..` in workspace
package.json (if '../..' points to the root of the project)
### How did you verify your code works?
Added a test

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-03 02:38:55 -07:00
robobun
693e7995bb Use cached structure in JSBunRequest::clone (#23202)
## Summary

Replace `createJSBunRequestStructure()` call with direct access to the
cached structure in `JSBunRequest::clone()` method for better
performance.

## Changes

- Updated `JSBunRequest::clone()` to use
`m_JSBunRequestStructure.getInitializedOnMainThread()` instead of
calling `createJSBunRequestStructure()`

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
2025-10-02 21:42:47 -07:00
pfg
79e0aa9bcf bun:test performance regression fix (#23199)
### What does this PR do?

Fixes #23120

bun:test changes introduced an added 16-100ms sleep between test files.
For a test suite with many fast-running test files, this caused
significant impact. Elysia's test suite was running 2x slower (1.8s →
3.9s).

<img width="646" height="289" alt="image"
src="https://github.com/user-attachments/assets/2ecd8c3e-984c-4a9a-a988-a911576b87c4"
/>


### How did you verify your code works?

Running elysia test suite & minimized reproduction case

<details>

<summary>Minimzed reproduction case</summary>

```ts
// full2.test.ts
import { it } from 'bun:test'

it("timeout", () => {
	setTimeout(() => {}, 295000);
}, 0);

// bench.ts
import {$} from "bun";

await $`rm -rf tests`;
await $`mkdir -p tests`;
for (let i = 0; i < 128; i += 1) {
    await Bun.write(`tests/${i}.test.ts`, `
        for (let i = 0; i < 1000; i ++) {
            it("test${i}", () => {}, 0);
        }
    `);
}
Bun.spawnSync({
    cmd: ["hyperfine", ...["bun-1.2.22", "bun-1.2.23+wakeup", "bun-1.2.23"].map(v => `${v} test ./full2.test.ts tests`)],
    stdio: ["inherit", "inherit", "inherit"],
});
```

</details>
2025-10-02 20:12:59 -07:00
pfg
d99d622472 Rereun-each fix (#23168)
### What does this PR do?

Fix --rerun-each. Fixes #21409

### How did you verify your code works?

Test case

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-02 19:12:45 -07:00
Ciro Spaciari
55f8e8add3 fix(Bun.SQL) time should be represented as a string and date as a time (#23193)
### What does this PR do?
Time should be represented as HH:MM:SS or HHH:MM:SS string
### How did you verify your code works?
Test

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-02 19:00:14 -07:00
Ciro Spaciari
84f94ca6dd fix(Bun.RedisClient) keep it alive when connecting (#23195)
### What does this PR do?
Fixes https://github.com/oven-sh/bun/issues/23178
Fixes https://github.com/oven-sh/bun/issues/23187
Fixes https://github.com/oven-sh/bun/issues/23198
### How did you verify your code works?
Test

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-02 18:50:05 -07:00
robobun
86924f36e8 Add 'bun why' to help menu (#23197)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Alistair Smith <hi@alistair.sh>
2025-10-02 18:43:10 -07:00
Alistair Smith
3ca89abacf remove 2025-10-02 18:33:40 -07:00
Alistair Smith
2f02e4e31d Merge branch 'main' of github.com:oven-sh/bun into ali/react 2025-10-02 18:21:29 -07:00
Alistair Smith
efb508e2ae chore: Bump & pin React 2025-10-02 18:14:47 -07:00
Alistair Smith
86af3dd034 fix test 2025-10-02 17:33:33 -07:00
autofix-ci[bot]
a6d3808ad8 [autofix.ci] apply automated fixes 2025-10-02 22:54:04 +00:00
Ciro Spaciari
4a86d070cf revert 6ab3d93 2025-10-02 15:53:19 -07:00
Ciro Spaciari
6ab3d931c9 opsie 2025-10-02 15:50:58 -07:00
Alistair Smith
2153fe4163 Merge branch 'main' of github.com:oven-sh/bun into ali/react 2025-10-02 15:50:40 -07:00
Ciro Spaciari
76545140af fix(node:http) fix closing socket after upgraded to websocket (#23150)
### What does this PR do?
handle socket upgrade in NodeHTTP.cpp
### How did you verify your code works?
Run the test added with asan it should catch the bug

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-02 14:55:28 -07:00
pfg
2caa5dc8f2 Passthrough anyerror when using handleOom (#23176)
### What does this PR do?

Previously, handleOom(anyerror!T) would return T and panic for
OutOfMemory for any error. fixes it to return anyerror!T for this case.

### How did you verify your code works?

CI

---------

Co-authored-by: taylor.fish <contact@taylor.fish>
2025-10-02 14:11:29 -07:00
SUZUKI Sosuke
d7eebef6f8 Upgrade WebKit (#23122)
### What does this PR do?

- **Use `Latin1Character` instead of `LChar`**
- **Fix for
0875bc8f62**

### How did you verify your code works?

---

# WebKit Update Summary (September 2025)

## Overview
This document summarizes the major changes in WebKit/JavaScriptCore from
the September 2025 update. The update includes approximately 254
JSC-related commits with significant improvements to performance,
stability, and developer experience.

## Critical Bug Fixes

### Memory Safety
- **operationMaterializeObjectInOSR fix** (5c7aadfa0a96): Fixed
uninitialized Butterfly storage during OSR exits with sunk Array
allocations. This prevents potential crashes when arrays with holes are
materialized during OSR exit.
- **FTL materialization fixes** (a72d19840714, ed1e6fe03899): Added
missing internal object type handling in FTL materialization, improving
stability during optimization bailouts.

### Promise and Async Improvements
- **JSPromiseReaction object** (a1cb5e087a46, later reverted in
b0566a4db201): Initially introduced to improve promise reaction handling
but was reverted due to compatibility issues with Bun's modifications.
- **Async stack traces enhancements**:
  - Added support for `Promise.any` in async stack traces (d9a997b3edaa)
- Added empty JSValue checking for async stack trace safety
(9d26223d4bcb)
- Promise.all support was added and later reverted due to performance
concerns

## Performance Optimizations

### JIT Compiler Improvements
- **B3 Immutable Loads** (570a3530f949, 62300f8db3d9): Added
immutability annotations and CSE optimizations for loads that can look
for targets in dominators
- **BBQ JIT enhancements**:
  - Fixed callee-save register handling (c7ae05719045)
  - Simplified F32 copysign operations (e0651af57025)
- **DFG optimizations**:
- Fixed RegExp constant folding with materialized NewRegExp nodes
(7b53a04a5afa)
- Improved RegExp object node handling in strength reduction
(eeb65e05095b)

### WebAssembly Improvements
- **WASM SIMD Support**:
- Added v128 support for IPInt call and tail-call instructions
(73f0c9d430cb)
- Implemented v128 support in local.get, local.set, global.get,
global.set (67d7bf15139a)
  - Added x86_64 SIMD integer arithmetic and float instructions
- **WASM Memory Management**:
- Introduced WasmInstanceAnchor for better instance lifecycle management
(f9f1ed183bf7)
- Attached AbstractHeap to wasm memory access for better optimization
(f183c6f7def4)
  - Added signal handling for null checks in wasm (bf18b5b709f3)
- **WASM Debugging**: Added LLDB debugging infrastructure for
WebAssembly (e03c10225cc8)

## API and Language Features

### Iterator Helpers
- Merged `Iterator.prototype.sliding` into `Iterator.prototype.windows`
(1d49e823702d)
- Optimized iterator next method calls using CachedCall (5ee92514060c)

### Math Extensions
- Improved performance of `Math.sumPrecise` implementation
(602294057337)

### Error Handling
- Enhanced error messages for for-of loops without Symbol.iterator
(0051bbf2491f)

## Infrastructure Changes

### Character Type Refactoring
- **LChar to Latin1Character rename** (63b97b511366, 1424f0687876):
Major refactoring replacing the `LChar` type with `Latin1Character`
throughout the codebase for better clarity
- Additional fixes for Latin1Character usage (711eab3243f0,
50bf8e6fd4ca, 88e29ab76aec)

### Build System
- Fixed builds with GCC 15.x (e33b18bc59d6)
- Added gitattributes for JSC test files (82c4cc796da6)
- Improved test runner with comprehensive verbose logging (7ef95c177a42)
- Added memory-limited annotations for tests using excessive memory
(b991cd17d612)

### Testing Infrastructure
- Improved handling of missing test executables (db1e3bbb3be2)
- Added support for non-customized ICU 74.2 in intl tests (c922a28b6642)
- Fixed various test configuration issues and timeouts

## Bun-Specific Modifications

### Preserved Customizations
- Maintained `BUN_JSC_ADDITIONS` for Bun-specific features
- Kept async context support for AsyncLocalStorage
- Preserved V8 heap snapshot compatibility layer
- Maintained custom inspector extensions

### Conflicts Resolved
- Successfully merged upstream changes while preserving Bun's event loop
integration
- Resolved conflicts in promise handling while maintaining Bun's async
behavior
- Fixed re-declaration issues with `isAsyncFrame` for async stack traces

## Breaking Changes and Reverts

### Reverted Features
1. **JSPromiseReaction object**: Reverted due to conflicts with Bun's
promise handling
2. **Promise.all async stack trace support**: Reverted due to ~4%
performance regression in JetStream3/doxbee-async benchmark
3. **Array.prototype.flat C++ implementation**: Reverted (reason not
specified in commit)

## Security Improvements
- Type safety improvements with uncheckedDowncast for Wasm::Callee
(48425afd643d)
- Added bounds checking and validation for Wasm array operations
(b5148db1c4c1)
- Improved memory safety with proper initialization of materialized
objects

## Platform Support
- macOS: Continued support for x64/arm64
- Linux: Maintained glibc/musl compatibility
- Windows: Preserved x64 support
- Fixed platform-specific alignment issues for x86_64 (94a60eb123c5)

## Notable Debugging Enhancements
- LLDB infrastructure for WebAssembly debugging
- Improved verbose command logging in test runners
- Enhanced stack trace capabilities for async functions
- Better error reporting for missing Symbol.iterator

## Performance Metrics
- Several memory optimizations for test execution
- JIT memory reservation size adjustments for debug builds
- Optimized iterator operations with cached calls
- Improved Math.sumPrecise performance

## Future Considerations
- The JSPromiseReaction implementation may need revisiting with adjusted
architecture
- Async stack trace support for Promise.all requires performance
optimization
- Continued work on WASM SIMD support for additional operations

## Migration Notes for Bun Team
1. **LChar usage**: All references to `LChar` have been replaced with
`Latin1Character`
2. **Promise handling**: The reverted JSPromiseReaction changes indicate
potential architectural conflicts that may need addressing
3. **Test configuration**: New memory-limited annotations should be used
for memory-intensive tests
4. **Build flags**: Ensure USE_BUN_JSC_ADDITIONS and USE_BUN_EVENT_LOOP
remain enabled
2025-10-01 17:16:25 -07:00
SUZUKI Sosuke
861fdacebc Enable --useExplicitResourceManagement by default (#23155)
### What does this PR do?

This PR enables `--useExplicitResourceManagement` JSC option by default,
to expose following builtins:

- `DisposableStack`
- `AsyncDisposableStack`
- `Iterator@@dispose`
- `AsyncIterator@@asyncDispose`

### How did you verify your code works?

These features are fully tested on JSC side.
2025-10-01 15:29:48 -07:00
pfg
9e6ba35ff7 Allow multiple inline snapshots in one call if they are the same (#23117)
Multiple inline snapshots from one call should be avoided because they
will cause problems if one changes but not the other, but this allows
them if they both have the same value.

### What does this PR do?

bad:

```ts
function oops(a) {
  expect(a).toMatchInlineSnapshot();
}
test("whoops", () => {
  oops(1);
  oops(2);
});
```

```
2 |   expect(a).toMatchInlineSnapshot();
                                      ^
error: Failed to update inline snapshot: Multiple inline snapshots on the same line must all have the same value:
Expected: 1
Received: 2
    at /Users/pfg/Dev/Node/bun/repro.ts:2:35
```

acceptable:

```ts
function ok(a) {
  expect(a).toMatchInlineSnapshot(`1`);
}
test("whokay", () => {
  ok(1);
  ok(1);
});
```

```
✓ whokay

 1 pass
 0 fail
 snapshots: +1 added
 2 expect() calls
```

### How did you verify your code works?

TODO: add tests

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-10-01 12:09:26 -07:00
Alistair Smith
6977b36215 change 2025-09-30 22:04:08 -07:00
pfg
613aea1787 run beforeAll before the first file and afterAll after the last file (#23113)
Fixes #23066

Reverts the breaking change to this order made in #22534
2025-09-30 21:47:31 -07:00
pfg
1fb9be3880 Re-enable afterAll inside a test (#23110)
Fixes #23064, Fixes #23077

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
2025-09-30 19:41:35 -07:00
Alistair Smith
ceaab9eda3 tests: Fix spacing in routes test expectation 2025-09-30 19:33:14 -07:00
Alistair Smith
f262e32368 tidy 2025-09-30 19:18:21 -07:00
Alistair Smith
69a76d44f9 types 2025-09-30 18:52:50 -07:00
Alistair Smith
fc9538baf1 move 2025-09-30 18:46:34 -07:00
Alistair Smith
72b7956385 remove old property 2025-09-30 18:13:46 -07:00
Alistair Smith
62b296bb43 message 2025-09-30 18:08:10 -07:00
Alistair Smith
cb14f70a43 remove dated .auto() implementation 2025-09-30 18:05:30 -07:00
Alistair Smith
38511375f8 unused for now 2025-09-30 17:50:14 -07:00
Alistair Smith
06cfe2ead1 bump react 2025-09-30 17:48:05 -07:00
Alistair Smith
4f219503fe fix production.test.ts resolving bun-framework-react 2025-09-30 17:41:22 -07:00
Alistair Smith
b2353d687e Merge branch 'main' of github.com:oven-sh/bun into ali/react 2025-09-30 17:25:53 -07:00
Alistair Smith
65e66099f7 fix: updated load expectation 2025-09-30 17:25:25 -07:00
Meghan Denny
f19a1cc3a5 test: break up node-http.test.ts (#23125) 2025-09-30 17:25:17 -07:00
taylor.fish
eac82e2184 Fix memory.deinit; handle more types (#23032)
* Fix `memory.deinit`; the previous PR erroneously added non-comptime
code in a comptime expression, which would result in a compile error
when trying to deinit an optional
* Handle arrays (distinct from slices)
* Handle error unions
* Disallow untagged unions, as this is probably an error; usually a
manual deinit impl is needed if untagged unions are involved
* Make switch exhaustive so we know we're not missing other types
(thanks @pfgithub)

(For internal tracking: fixes STAB-1295)
2025-09-30 16:14:55 -07:00