Merge branch 'main' into don/ci/zlint

.github/workflows/lint.yml

@@ -20,3 +20,11 @@ jobs:
           bun-version: ${{ env.BUN_VERSION }}
       - name: Lint
         run: bunx oxlint --config oxlint.json --quiet --format github
+
+  lint-zig:
+    name: "ZLint"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ZLint
+        uses: DonIsaac/zlint-action@main

src/bindgen.zig

@@ -1,9 +0,0 @@
-pub const bindgen = true;
-
-pub const main = @import("./bun.js/bindings/bindings-generator.zig").main;
-pub export fn PLCrashReportHandler(_: ?*anyopaque) void {}
-pub export fn mkdirp(_: ?*anyopaque) void {}
-pub const build_options = @import("build_options");
-pub const bun = @import("./BunObject.zig");
-pub const JavaScriptCore = @import("./jsc.zig");
-pub const C = @import("./c.zig");

src/bundler/bundle_v2.zig

@@ -17740,9 +17740,9 @@ pub const AstBuilder = struct {
     }
 
     pub fn pushScope(p: *AstBuilder, kind: Scope.Kind) *js_ast.Scope {
-        try p.scopes.ensureUnusedCapacity(p.allocator, 1);
-        try p.current_scope.children.ensureUnusedCapacity(p.allocator, 1);
-        const scope = try p.allocator.create(Scope);
+        p.scopes.ensureUnusedCapacity(p.allocator, 1) orelse bun.outOfMemory();
+        p.current_scope.children.ensureUnusedCapacity(p.allocator, 1) orelse bun.outOfMemory();
+        const scope = p.allocator.create(Scope) orelse bun.outOfMemory();
         scope.* = .{
             .kind = kind,
             .label_ref = null,

src/shell/shell.zig

@@ -669,19 +669,6 @@ pub const AST = struct {
 
         pub const Tag = enum { cmd, assigns };
 
-        pub fn to_pipeline_item(this: CmdOrAssigns, alloc: Allocator) PipelineItem {
-            switch (this) {
-                .cmd => |cmd| {
-                    const cmd_ptr = try alloc.create(Cmd);
-                    cmd_ptr.* = cmd;
-                    return .{ .cmd = cmd_ptr };
-                },
-                .assigns => |assigns| {
-                    return .{ .assign = assigns };
-                },
-            }
-        }
-
         pub fn to_expr(this: CmdOrAssigns, alloc: Allocator) !Expr {
             switch (this) {
                 .cmd => |cmd| {

zlint.json

@@ -0,0 +1,8 @@
+{
+  "$schema": "https://raw.githubusercontent.com/DonIsaac/zlint/refs/tags/v0.7.1/zlint.schema.json",
+  "ignore": ["zig-out", "vendor", "test", "build", "packages"],
+  "rules": {
+    "no-unresolved": "error",
+    "homeless-try": "warn"
+  }
+}