Compare commits

...

1 Commits

Author SHA1 Message Date
Claude Bot
474baf8279 Fix package manager segfault when metadata.url is empty
When HTTP responses have metadata but an empty or uninitialized url field,
accessing metadata.url directly can cause a segfault at address 0x00000040.
This adds defensive checks to use task.url_buf as a fallback when
metadata.url is empty.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-02 16:20:29 +00:00

View File

@@ -246,7 +246,7 @@ pub fn runTasks(
logger.Loc.Empty,
manager.allocator,
"<r><red><b>GET<r><red> {s}<d> - {d}<r>",
.{ metadata.url, response.status_code },
.{ if (metadata.url.len > 0) metadata.url else task.url_buf, response.status_code },
) catch |err| bun.handleOom(err);
} else {
manager.log.addWarningFmt(
@@ -254,7 +254,7 @@ pub fn runTasks(
logger.Loc.Empty,
manager.allocator,
"<r><yellow><b>GET<r><yellow> {s}<d> - {d}<r>",
.{ metadata.url, response.status_code },
.{ if (metadata.url.len > 0) metadata.url else task.url_buf, response.status_code },
) catch |err| bun.handleOom(err);
}
if (manager.subcommand != .remove) {
@@ -448,7 +448,7 @@ pub fn runTasks(
manager.allocator,
"<r><red><b>GET<r><red> {s}<d> - {d}<r>",
.{
metadata.url,
if (metadata.url.len > 0) metadata.url else task.url_buf,
response.status_code,
},
) catch |err| bun.handleOom(err);
@@ -459,7 +459,7 @@ pub fn runTasks(
manager.allocator,
"<r><yellow><b>GET<r><yellow> {s}<d> - {d}<r>",
.{
metadata.url,
if (metadata.url.len > 0) metadata.url else task.url_buf,
response.status_code,
},
) catch |err| bun.handleOom(err);