Compare commits

...

1 Commits

Author SHA1 Message Date
Meghan Denny
304fc9ef4a node:net.Server: register the connection listener 2025-06-12 15:25:18 -07:00
2 changed files with 54 additions and 1 deletions

View File

@@ -2073,10 +2073,12 @@ function Server(options?, connectionListener?) {
if (typeof options === "function") {
connectionListener = options;
options = {};
this.on("connection", connectionListener);
} else if (options == null || typeof options === "object") {
options = { ...options };
if (typeof connectionListener === "function") this.on("connection", connectionListener);
} else {
throw $ERR_INVALID_ARG_TYPE("options", ["Object", "Function"], options);
throw $ERR_INVALID_ARG_TYPE("options", "object", options);
}
// https://nodejs.org/api/net.html#netcreateserveroptions-connectionlistener

View File

@@ -0,0 +1,51 @@
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');
const SIZE = 2E6;
const N = 10;
const buf = Buffer.alloc(SIZE, 'a');
const server = net.createServer(function(socket) {
socket.setNoDelay();
socket.on('error', common.mustCall(() => socket.destroy()))
.on('close', common.mustCall(() => server.close()));
for (let i = 0; i < N; ++i) {
socket.write(buf, () => {});
}
socket.end();
}).listen(0, function() {
const conn = net.connect(this.address().port);
conn.on('data', function(buf) {
assert.strictEqual(conn, conn.pause());
setTimeout(function() {
conn.destroy();
}, 20);
});
});