more

src/bun.js/webcore/ByteBlobLoader.zig

@@ -180,7 +180,7 @@ pub fn toBufferedValue(this: *ByteBlobLoader, globalThis: *JSGlobalObject, actio
         return blob.toPromise(globalThis, action);
     }
 
-    return .zero;
+    return .js_undefined;
 }
 
 pub fn memoryCost(this: *const ByteBlobLoader) usize {

src/bun.js/webcore/ByteStream.zig

@@ -61,7 +61,7 @@ pub fn onStart(this: *@This()) streams.Start {
 
 pub fn value(this: *@This()) JSValue {
     const result = this.pending_value.get() orelse {
-        return .zero;
+        return .js_undefined;
     };
     this.pending_value.clearWithoutDeallocation();
     return result;
@@ -287,7 +287,7 @@ pub fn onPull(this: *@This(), buffer: []u8, view: jsc.JSValue) streams.Result {
     bun.debugAssert(this.buffer_action == null);
 
     if (this.buffer.items.len > 0) {
-        bun.assert(this.value() == .zero);
+        bun.assert(!this.pending_value.has());
         const to_write = @min(
             this.buffer.items.len - this.offset,
             buffer.len,
@@ -339,12 +339,12 @@ pub fn onPull(this: *@This(), buffer: []u8, view: jsc.JSValue) streams.Result {
 
 pub fn onCancel(this: *@This()) void {
     jsc.markBinding(@src());
-    const view = this.value();
+
     if (this.buffer.capacity > 0) this.buffer.clearAndFree();
     this.done = true;
     this.pending_value.deinit();
 
-    if (view != .zero) {
+    if (this.pending_value.has()) {
         this.pending_buffer = &.{};
         this.pending.result.deinit();
         this.pending.result = .{ .done = {} };

src/bun.js/webcore/TextEncoder.zig

@@ -21,7 +21,7 @@ pub export fn TextEncoder__encode8(
         const uint8array = jsc.JSValue.createUninitializedUint8Array(globalThis, result.written) catch return .zero;
         bun.assert(result.written <= buf.len);
         bun.assert(result.read == slice.len);
-        const array_buffer = uint8array.asArrayBuffer(globalThis) orelse return .zero;
+        const array_buffer = uint8array.asArrayBuffer(globalThis).?;
         bun.assert(result.written == array_buffer.len);
         @memcpy(array_buffer.byteSlice()[0..result.written], buf[0..result.written]);
         return uint8array;

src/bun.js/webcore/streams.zig

@@ -556,7 +556,7 @@ pub const Result = union(Tag) {
         if (jsc.VirtualMachine.get().isShuttingDown()) {
             var that = this.*;
             that.deinit();
-            return .zero;
+            return .js_undefined;
         }
 
         switch (this.*) {