mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
a0c5f3dc69
## Summary
- Fix assertion failure in `Bun.mmap` when `offset` or `size` options
are non-numeric values
- Add validation to reject negative `offset`/`size` with clear error
messages
Minimal reproduction: `Bun.mmap("", { offset: null });`
## Root Cause
`Bun.mmap` was calling `toInt64()` directly on the `offset` and `size`
options without validating they are numbers first. `toInt64()` has an
assertion that the value must be a number or BigInt, which fails when
non-numeric values like `null` or functions are passed.
## Test plan
- [x] Added tests for negative offset/size rejection
- [x] Added tests for non-number inputs (null, undefined)
- [x] `bun bd test test/js/bun/util/mmap.test.js` passes
Closes ENG-22413
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
100 lines
2.6 KiB
JavaScript
100 lines
2.6 KiB
JavaScript
import { describe, expect, it } from "bun:test";
|
|
import { gcTick, isWindows, tmpdirSync } from "harness";
|
|
import { join } from "path";
|
|
|
|
// TODO: We do not support mmap() on Windows. Maybe we can add it later.
|
|
describe.skipIf(isWindows)("Bun.mmap", async () => {
|
|
await gcTick();
|
|
const path = join(tmpdirSync(), "bun-mmap-test.txt");
|
|
await gcTick();
|
|
await Bun.write(path, "hello");
|
|
await gcTick();
|
|
|
|
it("mmap finalizer", async () => {
|
|
let map = Bun.mmap(path);
|
|
await gcTick();
|
|
const map2 = Bun.mmap(path);
|
|
|
|
map = null;
|
|
await gcTick();
|
|
});
|
|
|
|
it("mmap passed to other syscalls", async () => {
|
|
const map = Bun.mmap(path);
|
|
await gcTick();
|
|
await Bun.write(path + "1", map);
|
|
await gcTick();
|
|
const text = await (await Bun.file(path + "1")).text();
|
|
await gcTick();
|
|
|
|
expect(text).toBe(new TextDecoder().decode(map));
|
|
});
|
|
|
|
it("mmap sync", async () => {
|
|
const map = Bun.mmap(path);
|
|
await gcTick();
|
|
const map2 = Bun.mmap(path);
|
|
await gcTick();
|
|
|
|
const old = map[0];
|
|
await gcTick();
|
|
map[0] = 0;
|
|
await gcTick();
|
|
expect(map2[0]).toBe(0);
|
|
|
|
map2[0] = old;
|
|
await gcTick();
|
|
expect(map[0]).toBe(old);
|
|
await gcTick();
|
|
await Bun.write(path, "olleh");
|
|
await gcTick();
|
|
expect(new TextDecoder().decode(map)).toBe("olleh");
|
|
await gcTick();
|
|
});
|
|
|
|
it("mmap private", async () => {
|
|
await gcTick();
|
|
const map = Bun.mmap(path, { shared: true });
|
|
await gcTick();
|
|
const map2 = Bun.mmap(path, { shared: false });
|
|
await gcTick();
|
|
const old = map[0];
|
|
|
|
await gcTick();
|
|
map2[0] = 0;
|
|
await gcTick();
|
|
expect(map2[0]).toBe(0);
|
|
await gcTick();
|
|
expect(map[0]).toBe(old);
|
|
await gcTick();
|
|
});
|
|
|
|
it("mmap rejects negative offset", () => {
|
|
expect(() => Bun.mmap(path, { offset: -1 })).toThrow("offset must be a non-negative integer");
|
|
});
|
|
|
|
it("mmap rejects negative size", () => {
|
|
expect(() => Bun.mmap(path, { size: -1 })).toThrow("size must be a non-negative integer");
|
|
});
|
|
|
|
it("mmap handles non-number offset/size without crashing", () => {
|
|
// These should not crash - non-number values coerce to 0 per JavaScript semantics
|
|
// Previously these caused assertion failures (issue ENG-22413)
|
|
|
|
// null coerces to 0, which is valid for offset
|
|
expect(() => {
|
|
Bun.mmap(path, { offset: null });
|
|
}).not.toThrow();
|
|
|
|
// size: null coerces to 0, which is invalid (EINVAL), but shouldn't crash
|
|
expect(() => {
|
|
Bun.mmap(path, { size: null });
|
|
}).toThrow("EINVAL");
|
|
|
|
// undefined is ignored (property not set)
|
|
expect(() => {
|
|
Bun.mmap(path, { offset: undefined });
|
|
}).not.toThrow();
|
|
});
|
|
});
|