mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
344b2c1dfe
## Summary
- Fix bug where `Response.clone()` would lock the original response's
body when `response.body` was accessed before cloning
- Apply the same fix to `Request.clone()`
## Root Cause
When `response.body` was accessed before calling `response.clone()`, the
original response's body would become locked after cloning. This
happened because:
1. When the cloned response was wrapped with `toJS()`,
`checkBodyStreamRef()` was called which moved the stream from
`Locked.readable` to `js.gc.stream` and cleared `Locked.readable`
2. The subsequent code tried to get the stream from `Locked.readable`,
which was now empty, so the body cache update was skipped
3. The JavaScript-level body property cache still held the old locked
stream
## Fix
Updated the cache update logic to:
1. For the cloned response: use `js.gc.stream.get()` instead of
`Locked.readable.get()` since `toJS()` already moved the stream
2. For the original response: use `Locked.readable.get()` which still
holds the teed stream since `checkBodyStreamRef` hasn't been called yet
## Reproduction
```javascript
const readableStream = new ReadableStream({
start(controller) {
controller.enqueue(new TextEncoder().encode("Hello, world!"));
controller.close();
},
});
const response = new Response(readableStream);
console.log(response.body?.locked); // Accessing body before clone
const cloned = response.clone();
console.log(response.body?.locked); // Expected: false, Actual: true ❌
console.log(cloned.body?.locked); // Expected: false, Actual: false ✅
```
## Test plan
- [x] Added regression tests for `Response.clone()` in
`test/js/web/fetch/response.test.ts`
- [x] Added regression test for `Request.clone()` in
`test/js/web/request/request.test.ts`
- [x] Verified tests fail with system bun (before fix) and pass with
debug build (after fix)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
77 lines
2.3 KiB
TypeScript
77 lines
2.3 KiB
TypeScript
import { expect, test } from "bun:test";
|
|
|
|
test("undefined args don't throw", () => {
|
|
const request = new Request("https://example.com/", {
|
|
body: undefined,
|
|
"credentials": undefined,
|
|
"redirect": undefined,
|
|
"method": undefined,
|
|
"mode": undefined,
|
|
});
|
|
|
|
expect(request.method).toBe("GET");
|
|
});
|
|
|
|
test("request can receive undefined signal", async () => {
|
|
const request = new Request("http://example.com/", {
|
|
method: "POST",
|
|
headers: {
|
|
"Content-Type": "text/bun;charset=utf-8",
|
|
},
|
|
body: "bun",
|
|
signal: undefined,
|
|
});
|
|
expect(request.method).toBe("POST");
|
|
// @ts-ignore
|
|
const clone = new Request(request);
|
|
expect(clone.method).toBe("POST");
|
|
expect(clone.headers.get("content-type")).toBe("text/bun;charset=utf-8");
|
|
expect(await request.text()).toBe("bun");
|
|
expect(await clone.text()).toBe("bun");
|
|
});
|
|
|
|
test("request can receive null signal", async () => {
|
|
const request = new Request("http://example.com/", {
|
|
method: "POST",
|
|
headers: {
|
|
"Content-Type": "text/bun;charset=utf-8",
|
|
},
|
|
body: "bun",
|
|
signal: null,
|
|
});
|
|
expect(request.method).toBe("POST");
|
|
// @ts-ignore
|
|
const clone = new Request(request);
|
|
expect(clone.method).toBe("POST");
|
|
expect(clone.headers.get("content-type")).toBe("text/bun;charset=utf-8");
|
|
expect(await request.text()).toBe("bun");
|
|
expect(await clone.text()).toBe("bun");
|
|
});
|
|
|
|
test("clone() does not lock original body when body was accessed before clone", async () => {
|
|
const readableStream = new ReadableStream({
|
|
start(controller) {
|
|
controller.enqueue(new TextEncoder().encode("Hello, world!"));
|
|
controller.close();
|
|
},
|
|
});
|
|
|
|
const request = new Request("http://example.com", { method: "POST", body: readableStream });
|
|
|
|
// Access body before clone (this triggers the bug in the unfixed version)
|
|
const bodyBeforeClone = request.body;
|
|
expect(bodyBeforeClone?.locked).toBe(false);
|
|
|
|
const cloned = request.clone();
|
|
|
|
// Both should be unlocked after clone
|
|
expect(request.body?.locked).toBe(false);
|
|
expect(cloned.body?.locked).toBe(false);
|
|
|
|
// Both should be readable
|
|
const [originalText, clonedText] = await Promise.all([request.text(), cloned.text()]);
|
|
|
|
expect(originalText).toBe("Hello, world!");
|
|
expect(clonedText).toBe("Hello, world!");
|
|
});
|