mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 18:38:55 +00:00
## Summary - Refactor 16 test files to use async `Bun.spawn` instead of `Bun.spawnSync` - Wrap tests in `describe.concurrent` blocks for parallel execution - Use `await using` for automatic resource cleanup ## Performance Improvement | Test File | Before | After | Improvement | |-----------|--------|-------|-------------| | `node-module-module.test.js` (28 tests) | ~325ms | ~185ms | **43% faster** | | `non-english-import.test.js` (3 tests) | ~238ms | ~157ms | **34% faster** | ## Files Changed - `test/cli/run/commonjs-invalid.test.ts` - `test/cli/run/commonjs-no-export.test.ts` - `test/cli/run/empty-file.test.ts` - `test/cli/run/jsx-symbol-collision.test.ts` - `test/cli/run/run-cjs.test.ts` - `test/cli/run/run-extensionless.test.ts` - `test/cli/run/run-shell.test.ts` - `test/cli/run/run-unicode.test.ts` - `test/js/bun/resolve/non-english-import.test.js` - `test/js/node/module/node-module-module.test.js` - `test/regression/issue/00631.test.ts` - `test/regression/issue/03216.test.ts` - `test/regression/issue/03830.test.ts` - `test/regression/issue/04011.test.ts` - `test/regression/issue/04893.test.ts` - `test/regression/issue/hashbang-still-works.test.ts` ## Test plan - [x] All refactored tests pass with `USE_SYSTEM_BUN=1 bun test <file>` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
45 lines
1.5 KiB
TypeScript
45 lines
1.5 KiB
TypeScript
import { describe, expect, it } from "bun:test";
|
|
import { mkdirSync, readFileSync, rmSync, writeFileSync } from "fs";
|
|
import { join } from "path";
|
|
import { bunEnv, bunExe, tmpdirSync } from "../../harness.js";
|
|
|
|
describe.concurrent("issue/00631", () => {
|
|
it("JSON strings escaped properly", async () => {
|
|
const testDir = tmpdirSync();
|
|
|
|
// Clean up from prior runs if necessary
|
|
rmSync(testDir, { recursive: true, force: true });
|
|
|
|
// Create a directory with our test package file
|
|
mkdirSync(testDir, { recursive: true });
|
|
writeFileSync(join(testDir, "package.json"), String.raw`{"testRegex":"\\a\n\\b\\"}`);
|
|
|
|
// Attempt to add a package, causing the package file to be parsed, modified,
|
|
// written, and reparsed. This verifies that escaped backslashes in JSON
|
|
// survive the roundtrip
|
|
await using proc = Bun.spawn({
|
|
cmd: [bunExe(), "add", "left-pad"],
|
|
env: bunEnv,
|
|
cwd: testDir,
|
|
stdout: "pipe",
|
|
stderr: "pipe",
|
|
});
|
|
const [stderr, exitCode] = await Promise.all([proc.stderr.text(), proc.exited]);
|
|
if (exitCode !== 0) {
|
|
console.log(stderr);
|
|
}
|
|
expect(exitCode).toBe(0);
|
|
|
|
const packageContents = readFileSync(join(testDir, "package.json"), { encoding: "utf8" });
|
|
expect(packageContents).toBe(String.raw`{
|
|
"testRegex": "\\a\n\\b\\",
|
|
"dependencies": {
|
|
"left-pad": "^1.3.0"
|
|
}
|
|
}`);
|
|
|
|
//// If successful clean up test artifacts
|
|
rmSync(testDir, { recursive: true });
|
|
});
|
|
});
|