robobun 3cb1b5c7dd Fix CSS parser crash with large floating-point values (#21907) (#21909)
## 🐛 Problem

Fixes #21907 - CSS parser was crashing with "integer part of floating
point value out of bounds" when processing extremely large
floating-point values like `3.40282e38px` (commonly generated by
TailwindCSS `.rounded-full` class).

### Root Cause Analysis

**This revealed a broader systemic issue**: The CSS parser was ported
from Rust, which has different float→integer conversion semantics than
Zig's `@intFromFloat`.

**Zig behavior**: `@intFromFloat` panics on out-of-range values
**Rust behavior**: `as` operator follows safe conversion rules:
- Finite values within range: truncate toward zero
- NaN: becomes 0  
- Positive infinity: becomes target max value
- Negative infinity: becomes target min value
- Out-of-range finite values: clamp to target range

The crash occurred throughout the CSS codebase wherever `@intFromFloat`
was used, not just in the original failing location.

## 🔧 Comprehensive Solution

### 1. New Generic `bun.intFromFloat` Function
Created a reusable function in `src/bun.zig` that implements
Rust-compatible conversion semantics:

```zig
pub fn intFromFloat(comptime Int: type, value: anytype) Int {
    // Handle NaN -> 0
    if (std.math.isNan(value)) return 0;
    
    // Handle infinities -> min/max bounds
    if (std.math.isPositiveInf(value)) return std.math.maxInt(Int);
    if (std.math.isNegativeInf(value)) return std.math.minInt(Int);
    
    // Handle out-of-range values -> clamp to bounds
    const min_float = @as(Float, @floatFromInt(std.math.minInt(Int)));
    const max_float = @as(Float, @floatFromInt(std.math.maxInt(Int)));
    if (value > max_float) return std.math.maxInt(Int);
    if (value < min_float) return std.math.minInt(Int);
    
    // Safe conversion for in-range values
    return @as(Int, @intFromFloat(value));
}
```

### 2. Systematic Replacement Across CSS Codebase
Replaced **all 18 instances** of `@intFromFloat` in `src/css/` with
`bun.intFromFloat`:

| File | Conversions | Purpose |
|------|-------------|---------|
| `css_parser.zig` | 2 × `i32` | CSS dimension serialization |
| `css_internals.zig` | 9 × `u32` | Browser target version parsing |
| `values/color.zig` | 4 × `u8` | Color component conversion |
| `values/color_js.zig` | 1 × `i64→u8` | Alpha channel processing |
| `values/percentage.zig` | 1 × `i32` | Percentage value handling |
| `properties/custom.zig` | 1 × `i32` | Color helper function |

### 3. Comprehensive Test Coverage
- **New test suite**: `test/internal/int_from_float.test.ts` with inline
snapshots
- **Enhanced regression test**: `test/regression/issue/21907.test.ts`
covering all conversion types
- **Real-world testing**: Validates actual CSS processing with edge
cases

## 📊 esbuild Compatibility Analysis

Compared output with esbuild to ensure compatibility:

**Test CSS:**
```css
.test { border-radius: 3.40282e38px; }
.colors { color: rgb(300, -50, 1000); }
.boundaries { width: 2147483648px; }
```

**Key Differences:**
1. **Scientific notation format:**
   - esbuild: `3.40282e38` (no explicit + sign)  
   - Bun: `3.40282e+38` (explicit + sign)
   -  Both are mathematically equivalent and valid CSS

2. **Optimization strategy:**
   - esbuild: Preserves original literal values
   - Bun: Normalizes extremely large values + consolidates selectors
   -  Bun's more aggressive optimization results in smaller output

###  Question for Review

**@zackradisic** - Is it acceptable for Bun to diverge from esbuild in
this optimization behavior?

- **Pro**: More aggressive optimization (smaller output, consistent
formatting)
- **Con**: Different output format than esbuild
- **Impact**: Both outputs are functionally identical in browsers

Should we:
1.  Keep current behavior (more aggressive optimization)
2. 🔄 Match esbuild exactly (preserve literal notation)
3. 🎛️ Add flag to control this behavior

##  Testing & Validation

- [x] **Original crash case**: Fixed - no more panics with large
floating-point values
- [x] **All conversion types**: Tested i32, u32, u8, i64 conversions
with edge cases
- [x] **Browser compatibility**: Verified targets parsing works with
extreme values
- [x] **Color processing**: Confirmed RGB/RGBA values properly clamped
to 0-255 range
- [x] **Performance**: No regression - conversions are equally fast
- [x] **Real-world**: TailwindCSS projects with `.rounded-full` work
without crashes
- [x] **Inline snapshots**: Capture exact expected output for future
regression detection

## 🎯 Impact

### Before (Broken)
```bash
$ bun build styles.css
============================================================
panic: integer part of floating point value out of bounds
```

### After (Working)
```bash
$ bun build styles.css  
Bundled 1 module in 93ms
  styles.css  121 bytes  (asset)
```

-  **Fixes crashes** when using TailwindCSS `.rounded-full` class on
Windows
-  **Maintains backward compatibility** for existing projects  
-  **Improves robustness** across all CSS float→int conversions
-  **Better optimization** with consistent value normalization

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-08-15 20:59:50 -07:00
2025-08-14 22:42:05 -07:00
2024-12-26 11:48:30 -08:00
2024-12-12 03:21:56 -08:00
2025-01-07 20:19:12 -08:00
2025-07-21 16:26:07 -07:00
2025-08-14 22:42:05 -07:00
2025-02-06 18:07:55 -08:00
2025-08-10 11:38:31 -07:00
2024-07-24 01:30:31 -07:00
2025-04-19 05:41:34 -07:00
2025-08-14 14:44:47 -07:00
2025-07-10 00:10:43 -07:00
2025-07-10 00:10:43 -07:00

Logo

Bun

stars Bun speed

Documentation   •   Discord   •   Issues   •   Roadmap

Read the docs →

What is Bun?

Bun is an all-in-one toolkit for JavaScript and TypeScript apps. It ships as a single executable called bun.

At its core is the Bun runtime, a fast JavaScript runtime designed as a drop-in replacement for Node.js. It's written in Zig and powered by JavaScriptCore under the hood, dramatically reducing startup times and memory usage.

bun run index.tsx             # TS and JSX supported out-of-the-box

The bun command-line tool also implements a test runner, script runner, and Node.js-compatible package manager. Instead of 1,000 node_modules for development, you only need bun. Bun's built-in tools are significantly faster than existing options and usable in existing Node.js projects with little to no changes.

bun test                      # run tests
bun run start                 # run the `start` script in `package.json`
bun install <pkg>             # install a package
bunx cowsay 'Hello, world!'   # execute a package

Install

Bun supports Linux (x64 & arm64), macOS (x64 & Apple Silicon) and Windows (x64).

Linux users — Kernel version 5.6 or higher is strongly recommended, but the minimum is 5.1.

x64 users — if you see "illegal instruction" or similar errors, check our CPU requirements

# with install script (recommended)
curl -fsSL https://bun.com/install | bash

# on windows
powershell -c "irm bun.com/install.ps1 | iex"

# with npm
npm install -g bun

# with Homebrew
brew tap oven-sh/bun
brew install bun

# with Docker
docker pull oven/bun
docker run --rm --init --ulimit memlock=-1:-1 oven/bun

Upgrade

To upgrade to the latest version of Bun, run:

bun upgrade

Bun automatically releases a canary build on every commit to main. To upgrade to the latest canary build, run:

bun upgrade --canary

View canary build

Guides

Contributing

Refer to the Project > Contributing guide to start contributing to Bun.

License

Refer to the Project > License page for information about Bun's licensing.

Description
Bun is a fast, incrementally adoptable all-in-one JavaScript, TypeScript & JSX toolkit. Use individual tools like bun test or bun install in Node.js projects, or adopt the complete stack with a fast JavaScript runtime, bundler, test runner, and package manager built in. Bun aims for 100% Node.js compatibility.
Readme 680 MiB
Languages
Zig 60.5%
C++ 24.9%
TypeScript 8.3%
C 3.3%
JavaScript 1.4%
Other 1.1%