## Summary This PR implements support for `localAddress` and `localPort` options in TCP connections, allowing users to bind outgoing connections to a specific local IP address and port. This addresses issue #6888 and implements Node.js-compatible behavior for these options. ## Changes ### C Layer (uSockets) - **`bsd.c`**: Modified `bsd_create_connect_socket()` to accept a `local_addr` parameter and call `bind()` before `connect()` when a local address is specified - **`context.c`**: Updated `us_socket_context_connect()` and `start_connections()` to parse and pass local address parameters through the connection flow - **`libusockets.h`**: Updated public API signatures to include `local_host` and `local_port` parameters - **`internal.h`**: Added `local_host` and `local_port` fields to `us_connecting_socket_t` structure - **`openssl.c`**: Updated SSL connection function to match the new signature ### Zig Layer - **`SocketContext.zig`**: Updated `connect()` method to accept and pass through `local_host` and `local_port` parameters - **`socket.zig`**: Modified `connectAnon()` to handle local address binding, including IPv6 bracket removal and proper memory management - **`Handlers.zig`**: Added `localAddress` and `localPort` fields to `SocketConfig` and implemented parsing from JavaScript options - **`Listener.zig`**: Updated connection structures to store and pass local binding information - **`socket.zig` (bun.js/api/bun)**: Modified `doConnect()` to extract and pass local address options - Updated all other call sites (HTTP, MySQL, PostgreSQL, Valkey) to pass `null, 0` for backward compatibility ### JavaScript Layer - **`net.ts`**: Enabled `localAddress` and `localPort` support by passing these options to `doConnect()` and removing TODO comments ### Tests - **`06888-localaddress.test.ts`**: Added comprehensive tests covering: - IPv4 local address binding - IPv4 local address and port binding - IPv6 local address binding (loopback) - Backward compatibility (connections without local address) ## Test Results All tests pass successfully: ``` ✓ TCP socket can bind to localAddress - IPv4 ✓ TCP socket can bind to localAddress and localPort - IPv4 ✓ TCP socket can bind to localAddress - IPv6 loopback ✓ TCP socket without localAddress works normally 4 pass, 0 fail ``` ## API Usage ```typescript import net from "net"; // Connect with a specific local address const client = net.createConnection({ host: "example.com", port: 80, localAddress: "192.168.1.100", // Bind to this local IP localPort: 0, // Let system assign port (optional) }); ``` ## Implementation Details The implementation follows the same flow as Node.js: 1. JavaScript options are parsed in `Handlers.zig` 2. Local address/port are stored in the connection configuration 3. The Zig layer processes and passes them to the C layer 4. The C layer parses the local address and calls `bind()` before `connect()` 5. Both IPv4 and IPv6 addresses are supported Memory management is handled properly throughout the stack, with appropriate allocation/deallocation at each layer. Closes #6888 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Bot <claude-bot@bun.sh> Co-authored-by: Claude <noreply@anthropic.com>
Tests
Finding tests
Tests are located in the test/ directory and are organized using the following structure:
test/js/- tests for JavaScript APIs.cli/- tests for commands, configs, and stdout.bundler/- tests for the transpiler/bundler.regression/- tests that reproduce a specific issue.harness.ts- utility functions that can be imported from any test.
The tests in test/js/ directory are further categorized by the type of API.
test/js/bun/- tests forBun-specific APIs.node/- tests for Node.js APIs.web/- tests for Web APIs, likefetch().first_party/- tests for npm packages that are built-in, likeundici.third_party/- tests for npm packages that are not built-in, but are popular, likeesbuild.
Running tests
To run a test, use Bun's built-in test command: bun test.
bun test # Run all tests
bun test js/bun # Only run tests in a directory
bun test sqlite.test.ts # Only run a specific test
If you encounter lots of errors, try running bun install, then trying again.
Writing tests
Tests are written in TypeScript (preferred) or JavaScript using Jest's describe(), test(), and expect() APIs.
import { describe, test, expect } from "bun:test";
import { gcTick } from "harness";
describe("TextEncoder", () => {
test("can encode a string", async () => {
const encoder = new TextEncoder();
const actual = encoder.encode("bun");
await gcTick();
expect(actual).toBe(new Uint8Array([0x62, 0x75, 0x6E]));
});
});
If you are fixing a bug that was reported from a GitHub issue, remember to add a test in the test/regression/ directory.
// test/regression/issue/02005.test.ts
import { it, expect } from "bun:test";
it("regex literal should work with non-latin1", () => {
const text = "这是一段要替换的文字";
expect(text.replace(new RegExp("要替换"), "")).toBe("这是一段的文字");
expect(text.replace(/要替换/, "")).toBe("这是一段的文字");
});
In the future, a bot will automatically close or re-open issues when a regression is detected or resolved.
Zig tests
These tests live in various .zig files throughout Bun's codebase, leveraging Zig's builtin test keyword.
Currently, they're not run automatically nor is there a simple way to run all of them. We will make this better soon.
TypeScript
Test files should be written in TypeScript. The types in packages/bun-types should be updated to support all new APIs. Changes to the .d.ts files in packages/bun-types will be immediately reflected in test files; no build step is necessary.
Writing a test will often require using invalid syntax, e.g. when checking for errors when an invalid input is passed to a function. TypeScript provides a number of escape hatches here.
// @ts-expect-error- This should be your first choice. It tells TypeScript that the next line should fail typechecking.// @ts-ignore- Ignore the next line entirely.// @ts-nocheck- Put this at the top of the file to disable typechecking on the entire file. Useful for autogenerated test files, or when ignoring/disabling type checks an a per-line basis is too onerous.