mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
6b3403a2b4
## Summary
- Fixed all `update-*.yml` workflows that were creating duplicate PRs
every week
## Problem
The update workflows (libarchive, zstd, cares, etc.) were using `${{
github.run_number }}` in the branch name, e.g.:
```yaml
branch: deps/update-libarchive-${{ github.run_number }}
```
This caused a new unique branch to be created on every workflow run, so
the `peter-evans/create-pull-request` action couldn't detect existing
PRs and would create duplicates.
**Evidence:** There are currently 8+ open duplicate PRs for libarchive
alone:
- #26432 deps: update libarchive to v3.8.5 (deps/update-libarchive-56)
- #26209 deps: update libarchive to v3.8.5 (deps/update-libarchive-55)
- #25955 deps: update libarchive to v3.8.5 (deps/update-libarchive-54)
- etc.
## Solution
Changed all workflows to use static branch names, e.g.:
```yaml
branch: deps/update-libarchive
```
This allows the action to:
1. Detect if an existing branch/PR already exists
2. Update the existing PR with new changes instead of creating a new one
3. Properly use `delete-branch: true` when the PR is merged
## Files Changed
- `.github/workflows/update-cares.yml`
- `.github/workflows/update-hdrhistogram.yml`
- `.github/workflows/update-highway.yml`
- `.github/workflows/update-libarchive.yml`
- `.github/workflows/update-libdeflate.yml`
- `.github/workflows/update-lolhtml.yml`
- `.github/workflows/update-lshpack.yml`
- `.github/workflows/update-root-certs.yml`
- `.github/workflows/update-sqlite3.yml`
- `.github/workflows/update-vendor.yml`
- `.github/workflows/update-zstd.yml`
## Test plan
- [x] Verified the change is syntactically correct
- [ ] Wait for next scheduled run of any workflow to verify it updates
existing PR instead of creating a new one
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
100 lines
3.9 KiB
YAML
100 lines
3.9 KiB
YAML
name: Update zstd
|
|
|
|
on:
|
|
schedule:
|
|
- cron: "0 1 * * 0"
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
check-update:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: write
|
|
pull-requests: write
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- name: Check zstd version
|
|
id: check-version
|
|
run: |
|
|
set -euo pipefail
|
|
|
|
# Extract the commit hash from the line after COMMIT
|
|
CURRENT_VERSION=$(awk '/[[:space:]]*COMMIT[[:space:]]*$/{getline; gsub(/^[[:space:]]+|[[:space:]]+$/,"",$0); print}' cmake/targets/CloneZstd.cmake)
|
|
|
|
if [ -z "$CURRENT_VERSION" ]; then
|
|
echo "Error: Could not find COMMIT line in CloneZstd.cmake"
|
|
exit 1
|
|
fi
|
|
|
|
# Validate that it looks like a git hash
|
|
if ! [[ $CURRENT_VERSION =~ ^[0-9a-f]{40}$ ]]; then
|
|
echo "Error: Invalid git hash format in CloneZstd.cmake"
|
|
echo "Found: $CURRENT_VERSION"
|
|
echo "Expected: 40 character hexadecimal string"
|
|
exit 1
|
|
fi
|
|
|
|
echo "current=$CURRENT_VERSION" >> $GITHUB_OUTPUT
|
|
|
|
LATEST_RELEASE=$(curl -sL https://api.github.com/repos/facebook/zstd/releases/latest)
|
|
if [ -z "$LATEST_RELEASE" ]; then
|
|
echo "Error: Failed to fetch latest release from GitHub API"
|
|
exit 1
|
|
fi
|
|
|
|
LATEST_TAG=$(echo "$LATEST_RELEASE" | jq -r '.tag_name')
|
|
if [ -z "$LATEST_TAG" ] || [ "$LATEST_TAG" = "null" ]; then
|
|
echo "Error: Could not extract tag name from GitHub API response"
|
|
exit 1
|
|
fi
|
|
|
|
LATEST_TAG_SHA=$(curl -sL "https://api.github.com/repos/facebook/zstd/git/refs/tags/$LATEST_TAG" | jq -r '.object.sha')
|
|
if [ -z "$LATEST_TAG_SHA" ] || [ "$LATEST_TAG_SHA" = "null" ]; then
|
|
echo "Error: Could not fetch SHA for tag $LATEST_TAG"
|
|
exit 1
|
|
fi
|
|
LATEST_SHA=$(curl -sL "https://api.github.com/repos/facebook/zstd/git/tags/$LATEST_TAG_SHA" | jq -r '.object.sha')
|
|
if [ -z "$LATEST_SHA" ] || [ "$LATEST_SHA" = "null" ]; then
|
|
echo "Error: Could not fetch SHA for tag $LATEST_TAG @ $LATEST_TAG_SHA"
|
|
exit 1
|
|
fi
|
|
|
|
if ! [[ $LATEST_SHA =~ ^[0-9a-f]{40}$ ]]; then
|
|
echo "Error: Invalid SHA format received from GitHub"
|
|
echo "Found: $LATEST_SHA"
|
|
echo "Expected: 40 character hexadecimal string"
|
|
exit 1
|
|
fi
|
|
|
|
echo "latest=$LATEST_SHA" >> $GITHUB_OUTPUT
|
|
echo "tag=$LATEST_TAG" >> $GITHUB_OUTPUT
|
|
|
|
- name: Update version if needed
|
|
if: success() && steps.check-version.outputs.current != steps.check-version.outputs.latest
|
|
run: |
|
|
set -euo pipefail
|
|
# Handle multi-line format where COMMIT and its value are on separate lines
|
|
sed -i -E '/[[:space:]]*COMMIT[[:space:]]*$/{n;s/[[:space:]]*([0-9a-f]+)[[:space:]]*$/ ${{ steps.check-version.outputs.latest }}/}' cmake/targets/CloneZstd.cmake
|
|
|
|
- name: Create Pull Request
|
|
if: success() && steps.check-version.outputs.current != steps.check-version.outputs.latest
|
|
uses: peter-evans/create-pull-request@v7
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
add-paths: |
|
|
cmake/targets/CloneZstd.cmake
|
|
commit-message: "deps: update zstd to ${{ steps.check-version.outputs.tag }} (${{ steps.check-version.outputs.latest }})"
|
|
title: "deps: update zstd to ${{ steps.check-version.outputs.tag }}"
|
|
delete-branch: true
|
|
branch: deps/update-zstd
|
|
body: |
|
|
## What does this PR do?
|
|
|
|
Updates zstd to version ${{ steps.check-version.outputs.tag }}
|
|
|
|
Compare: https://github.com/facebook/zstd/compare/${{ steps.check-version.outputs.current }}...${{ steps.check-version.outputs.latest }}
|
|
|
|
Auto-updated by [this workflow](https://github.com/oven-sh/bun/actions/workflows/update-zstd.yml)
|