Claude Bot 84545edc9f Fix crash when visiting properties in macro-generated objects
Fixes #24505

## Problem

Bun was crashing with segmentation faults when building projects that use
macros returning large objects. The crash was flaky and occurred during the
AST visiting phase when processing object properties.

The issue was in `visitExpr.zig` where property values, keys, and
initializers were being accessed using the unsafe `property.value.?` pattern
after checking `property.value != null`. While this appears safe, in
certain edge cases (particularly with macro-generated objects), the check
and use were not atomic, leading to potential null pointer dereferences.

## Solution

Replace the unsafe optional access patterns with Zig's safe optional
unwrapping syntax:

- Before: `if (property.value != null) { use(property.value.?); }`
- After: `if (property.value) |val| { use(val); }`

This ensures that the value is captured and used atomically, preventing
race conditions or other issues that could cause crashes.

Changes made in three locations:
1. e_jsx_element property visiting (lines 210-222)
2. e_object property visiting (lines 1088-1105)

## Test Plan

Added regression test `test/regression/issue/24505.test.ts` that:
- Creates a macro that generates an object with 50 properties
- Runs the build 3 times to catch flaky crashes
- Verifies no segmentation faults or panics occur

Tested with the original reproduction case from the issue - the visiting
phase no longer crashes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-08 10:26:34 +00:00
2025-10-07 20:08:57 -07:00
2025-11-05 11:19:07 -08:00
2025-11-01 19:58:13 -07:00
2024-12-26 11:48:30 -08:00
2024-12-12 03:21:56 -08:00
2025-10-05 04:28:25 -07:00
2025-01-07 20:19:12 -08:00
2025-10-25 21:34:24 -07:00
2025-11-07 04:40:29 -08:00
2022-09-03 20:54:15 -07:00
2025-10-22 12:13:14 -07:00
2024-07-24 01:30:31 -07:00
2025-07-10 00:10:43 -07:00
2025-07-10 00:10:43 -07:00
go
2021-08-11 13:56:03 -07:00

Logo

Bun

stars Bun speed

Documentation   •   Discord   •   Issues   •   Roadmap

Read the docs →

What is Bun?

Bun is an all-in-one toolkit for JavaScript and TypeScript apps. It ships as a single executable called bun.

At its core is the Bun runtime, a fast JavaScript runtime designed as a drop-in replacement for Node.js. It's written in Zig and powered by JavaScriptCore under the hood, dramatically reducing startup times and memory usage.

bun run index.tsx             # TS and JSX supported out-of-the-box

The bun command-line tool also implements a test runner, script runner, and Node.js-compatible package manager. Instead of 1,000 node_modules for development, you only need bun. Bun's built-in tools are significantly faster than existing options and usable in existing Node.js projects with little to no changes.

bun test                      # run tests
bun run start                 # run the `start` script in `package.json`
bun install <pkg>             # install a package
bunx cowsay 'Hello, world!'   # execute a package

Install

Bun supports Linux (x64 & arm64), macOS (x64 & Apple Silicon) and Windows (x64).

Linux users — Kernel version 5.6 or higher is strongly recommended, but the minimum is 5.1.

x64 users — if you see "illegal instruction" or similar errors, check our CPU requirements

# with install script (recommended)
curl -fsSL https://bun.com/install | bash

# on windows
powershell -c "irm bun.com/install.ps1 | iex"

# with npm
npm install -g bun

# with Homebrew
brew tap oven-sh/bun
brew install bun

# with Docker
docker pull oven/bun
docker run --rm --init --ulimit memlock=-1:-1 oven/bun

Upgrade

To upgrade to the latest version of Bun, run:

bun upgrade

Bun automatically releases a canary build on every commit to main. To upgrade to the latest canary build, run:

bun upgrade --canary

View canary build

Guides

Contributing

Refer to the Project > Contributing guide to start contributing to Bun.

License

Refer to the Project > License page for information about Bun's licensing.

Description
Bun is a fast, incrementally adoptable all-in-one JavaScript, TypeScript & JSX toolkit. Use individual tools like bun test or bun install in Node.js projects, or adopt the complete stack with a fast JavaScript runtime, bundler, test runner, and package manager built in. Bun aims for 100% Node.js compatibility.
Readme 760 MiB
Languages
Zig 60.6%
C++ 24.8%
TypeScript 8.3%
C 3.3%
JavaScript 1.4%
Other 1.1%