mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address additional review comments

Browse Source 
- Change catch parameter from `e: any` to `e: unknown` with safe error message extraction
- Log install stdout/stderr on failure for easier debugging

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Bot
2026-01-31 18:29:37 +00:00
parent 5e1b61c942
commit 483ccc63d5
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
test/regression/issue/26638.test.ts
View File

@@ -126,8 +126,16 @@ req.end();
}),
{ headers: { "Content-Type": "application/json" } },
);
} catch (e: any) {
return new Response(JSON.stringify({ success: false, error: e.message }), {
} catch (e: unknown) {
let errorMessage: string;
if (e instanceof Error) {
errorMessage = e.message;
} else if (typeof e === "object" && e !== null && "message" in e) {
errorMessage = String((e as { message: unknown }).message);
} else {
errorMessage = String(e);
}
return new Response(JSON.stringify({ success: false, error: errorMessage }), {
status: 500,
headers: { "Content-Type": "application/json" },
});
@@ -176,7 +184,15 @@ upload();
stdout: "pipe",
stderr: "pipe",
});
const installExitCode = await installProc.exited;
const [installStdout, installStderr, installExitCode] = await Promise.all([
installProc.stdout.text(),
installProc.stderr.text(),
installProc.exited,
]);
if (installExitCode !== 0) {
console.error("Install stdout:", installStdout);
console.error("Install stderr:", installStderr);
}
expect(installExitCode).toBe(0);
// Run the client