mirror of
https://github.com/oven-sh/bun
synced 2026-02-02 15:08:46 +00:00
Address additional review comments
- Change catch parameter from `e: any` to `e: unknown` with safe error message extraction - Log install stdout/stderr on failure for easier debugging Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -126,8 +126,16 @@ req.end();
|
|||||||
}),
|
}),
|
||||||
{ headers: { "Content-Type": "application/json" } },
|
{ headers: { "Content-Type": "application/json" } },
|
||||||
);
|
);
|
||||||
} catch (e: any) {
|
} catch (e: unknown) {
|
||||||
return new Response(JSON.stringify({ success: false, error: e.message }), {
|
let errorMessage: string;
|
||||||
|
if (e instanceof Error) {
|
||||||
|
errorMessage = e.message;
|
||||||
|
} else if (typeof e === "object" && e !== null && "message" in e) {
|
||||||
|
errorMessage = String((e as { message: unknown }).message);
|
||||||
|
} else {
|
||||||
|
errorMessage = String(e);
|
||||||
|
}
|
||||||
|
return new Response(JSON.stringify({ success: false, error: errorMessage }), {
|
||||||
status: 500,
|
status: 500,
|
||||||
headers: { "Content-Type": "application/json" },
|
headers: { "Content-Type": "application/json" },
|
||||||
});
|
});
|
||||||
@@ -176,7 +184,15 @@ upload();
|
|||||||
stdout: "pipe",
|
stdout: "pipe",
|
||||||
stderr: "pipe",
|
stderr: "pipe",
|
||||||
});
|
});
|
||||||
const installExitCode = await installProc.exited;
|
const [installStdout, installStderr, installExitCode] = await Promise.all([
|
||||||
|
installProc.stdout.text(),
|
||||||
|
installProc.stderr.text(),
|
||||||
|
installProc.exited,
|
||||||
|
]);
|
||||||
|
if (installExitCode !== 0) {
|
||||||
|
console.error("Install stdout:", installStdout);
|
||||||
|
console.error("Install stderr:", installStderr);
|
||||||
|
}
|
||||||
expect(installExitCode).toBe(0);
|
expect(installExitCode).toBe(0);
|
||||||
|
|
||||||
// Run the client
|
// Run the client
|
||||||
|
|||||||
Reference in New Issue
Block a user