mirror of
https://github.com/oven-sh/bun
synced 2026-02-09 10:28:47 +00:00
fix: address review comments
- Add disable_sigusr1 to bootStandalone options so standalone executables respect the --disable-sigusr1 flag - Replace inline snapshot with explicit toBe() for clearer output comparison Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -38,6 +38,7 @@ pub const Run = struct {
|
||||
.smol = ctx.runtime_options.smol,
|
||||
.debugger = ctx.runtime_options.debugger,
|
||||
.dns_result_order = DNSResolver.Order.fromStringOrDie(ctx.runtime_options.dns_result_order),
|
||||
.disable_sigusr1 = ctx.runtime_options.disable_sigusr1,
|
||||
}),
|
||||
.arena = arena,
|
||||
.ctx = ctx,
|
||||
|
||||
@@ -188,13 +188,11 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => {
|
||||
|
||||
const [stderr, exitCode] = await Promise.all([proc.stderr.text(), proc.exited]);
|
||||
|
||||
expect(output).toMatchInlineSnapshot(`
|
||||
"READY
|
||||
SIGNAL_1
|
||||
SIGNAL_2
|
||||
SIGNAL_3
|
||||
"
|
||||
`);
|
||||
expect(output).toBe(`READY
|
||||
SIGNAL_1
|
||||
SIGNAL_2
|
||||
SIGNAL_3
|
||||
`);
|
||||
expect(stderr).not.toContain("Bun Inspector");
|
||||
expect(exitCode).toBe(0);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user