mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 05:12:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,963 Commits 2,490 Branches 252 Tags
claude/fix-postgres-alignment-issue
Commit Graph

12963 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Claude Bot
bb679db31e Simplify Postgres array alignment fix using align(1) 
This is a much cleaner fix for the "panic: incorrect alignment" error
in postgres_types.zig:242. Instead of complex memory allocation, simply
set all struct fields to align(1) which allows the struct to work with
any alignment from network data.

Changes:
- Added `align(1)` to all i32 fields in PostgresBinarySingleDimensionArray
- Added `@alignCast` in slice() method to handle the alignment conversion
- Reverted complex memory allocation approach for simpler solution

This maintains the original struct layout and behavior while fixing
the alignment panic when casting network data to struct pointers.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-16 03:29:12 +00:00
Claude Bot
e4618043c4 Fix Postgres array alignment issue causing use-after-free panic 
This fixes the "panic: incorrect alignment" error that occurred in
postgres_types.zig:242 when processing binary array data from PostgreSQL.

The issue was caused by @alignCast failing when the network data wasn't
properly aligned for the struct type. The original code tried to directly
cast misaligned byte data to a struct pointer, which violates Zig's
alignment requirements.

## Root Cause
In PostgresBinarySingleDimensionArray.init(), the code used:
```zig
const this: *@This() = @alignCast(@ptrCast(@constCast(bytes.ptr)));
```

This would panic if bytes.ptr wasn't aligned to the struct's alignment
requirements (typically 4 bytes for i32 fields).

## Solution
- Read integer values safely using std.mem.readInt() with proper endianness
- Always allocate properly aligned memory using bun.default_allocator.alignedAlloc()
- Copy the original data to the aligned memory buffer
- Parse and set the struct fields explicitly instead of relying on memory layout

This ensures memory safety while maintaining compatibility with the existing
DataCell.deinit() infrastructure that expects bun.default_allocator allocations.

## Tests
- Added regression tests to verify the fix handles alignment correctly
- Added integration tests for array processing with various data sizes
- Verified that memory is properly allocated and can be freed correctly

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-16 01:18:09 +00:00
jarred-sumner-bot
44a7e6279e Make --console-depth=0 enable infinite depth instead of zero depth (#21038) 
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-14 07:45:20 -07:00
Jarred Sumner
7bb9a94d68 Implement test.coveragePathIgnorePatterns (#21013) 
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
 2025-07-14 05:08:32 -07:00
jarred-sumner-bot
3bba4e1446 Add --console-depth CLI flag and console.depth bunfig option (#21016) 
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: jarred-sumner-bot <220441119+jarred-sumner-bot@users.noreply.github.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
 2025-07-14 04:58:41 -07:00
Jarred Sumner
8cf4df296d Delete the merge conflict factory 
There are many situations where using `catch unreachable` is a reasonable or sometimes necessary decision. This rule causes many, many merge conflicts.
 2025-07-14 03:53:50 -07:00
Michael H
3ba9b5710e fix Bun.build with { sourcemap: true } (#21029) 2025-07-14 03:52:26 -07:00
Jarred Sumner
a102f85df2 make debug build logs less noisy 2025-07-14 03:11:10 -07:00
Michael H
e8289cc3ab fix os.networkInterfaces where scope_id should be scopeid (#21026) 2025-07-14 02:48:20 -07:00
jarred-sumner-bot
a69a9b4ea1 Fix test output filtering for skipped and todo tests (#21021) 
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: jarred-sumner-bot <220441119+jarred-sumner-bot@users.noreply.github.com>
 2025-07-14 02:46:55 -07:00
Jarred Sumner
3f283680dd Buffer stderr and stdout in bun:test reporting (#21023) 2025-07-14 00:55:35 -07:00
Jarred Sumner
2e02d9de28 Use ReadableStream.prototype.* in tests instead of new Response(...).* (#20937) 
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Alistair Smith <hi@alistair.sh>
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-14 00:47:53 -07:00
Jarred Sumner
9ac6690fb7 Update package.json 2025-07-13 23:13:04 -07:00
Michael H
8898c4c455 Vscode test runner support (#20645) 2025-07-13 21:57:44 -07:00
Jarred Sumner
499eac0d49 Enable SIMD multiline comment optimization (#13844) 
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com>
 2025-07-13 04:46:07 -07:00
Jarred Sumner
285f708fe6 Implement more v8::Array::New overloads, v8::Object::{Get,Set}, v8::Value::StrictEquals, v8::Array::Iterate (#20737) 
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: jarred <jarred@bun.sh>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Ben Grant <ben@bun.sh>
 2025-07-13 04:27:43 -07:00
Jarred Sumner
9cd9f534d5 Debian trixie does not support sfotware-properties-common 2025-07-13 02:34:13 -07:00
Jarred Sumner
f913a21709 Debian trixie does not support sfotware-properties-common 
https://github.com/llvm/llvm-project/issues/120608
 2025-07-13 02:29:27 -07:00
Jarred Sumner
a976a048b7 Delete unused and confusing bun-internal-test package (#21008) 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
 2025-07-13 02:23:50 -07:00
Jarred Sumner
22627eda9b CI 2025-07-13 01:56:14 -07:00
Jarred Sumner
d6d7251352 Fixes #14988 (#20928) 
Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude <noreply@anthropic.com>
 2025-07-12 18:22:54 -07:00
Zack Radisic
ac61b1d471 Use better function names for bun.String (#20999) 2025-07-12 18:19:16 -07:00
Antonio Anderson
0feddf716a fix(docs): use bun.sh in PowerShell install command to avoid rediret (#21001) 2025-07-12 18:16:09 -07:00
Zack Radisic
eae8fb34b8 Don't strip out debug symbols for lldb (#20874) 
Co-authored-by: CountBleck <Mr.YouKnowWhoIAm@protonmail.com>
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: Michael H <git@riskymh.dev>
Co-authored-by: 190n <ben@bun.sh>
Co-authored-by: Alistair Smith <hi@alistair.sh>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>
Co-authored-by: cirospaciari <6379399+cirospaciari@users.noreply.github.com>
Co-authored-by: Kai Tamkun <13513421+heimskr@users.noreply.github.com>
Co-authored-by: Claude <claude@anthropic.ai>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Jarred-Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Co-authored-by: Meghan Denny <meghan@bun.sh>
 2025-07-12 17:13:34 -07:00
Meghan Denny
c106f31345 test: delete bundler test temp folders upon success (#20990) 2025-07-12 10:59:50 -07:00
taylor.fish
0baf5b94e2 Fix bun add with multiple packages (#20987) 
Co-authored-by: Meghan Denny <meghan@bun.sh>
 2025-07-12 02:10:45 -07:00
Meghan Denny
7827df5745 [publish images] 2025-07-12 00:55:22 -07:00
Meghan Denny
dbd577cde6 ci: download exact version of node specifed (#20936) 
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com>
 2025-07-12 00:53:52 -07:00
Jarred Sumner
9e4700ee2d Remove unused Symbol.for(primitive) calls in bundler (#20888) 
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Jarred Sumner <Jarred-Sumner@users.noreply.github.com>
 2025-07-12 00:52:07 -07:00
Alistair Smith
6615a2c9d4 docs: add typescript migration note for declaring globals in jest (#20985) 2025-07-11 19:13:40 -07:00
Alistair Smith
c594e7ecc1 Add non-default-referenced ambient declaration file to globally declare test runner symbols (#20977) 2025-07-11 18:06:45 -07:00
Jarred Sumner
9e4f460d17 Improve tree-shaking of try statements in dead code (#20934) 2025-07-11 15:47:04 -07:00
190n
c49547cfa4 Fix #20972 (#20974) 2025-07-11 15:23:29 -07:00
Alistair Smith
ee7e1f7d2c fix #20978 (#20981) 2025-07-11 15:00:02 -07:00
Alistair Smith
70c22d41d6 types: NodeJS.ProcessEnv does not extend ImportMetaEnv (#20976) 2025-07-11 14:16:11 -07:00
Jarred Sumner
a059c76370 Include RAM in crash report message (#20954) 
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
 2025-07-11 12:45:49 -07:00
Meghan Denny
9bc559e09f console: fix printing of Response(Bun.file()) (#20933) 2025-07-11 11:37:44 -07:00
Alistair Smith
c82e4fb485 fix typo (#20962) 2025-07-10 22:57:14 -07:00
Alistair Smith
a8780632a6 fix typo 2025-07-10 22:56:21 -07:00
Alistair Smith
65ccb39778 Convert bun-types.test.ts to TS compiler api, fix forward-declared empty interfaces (#20960) 2025-07-10 22:47:42 -07:00
Jarred Sumner
ac55376161 [ci] Don't error if machine hits permission error when modifying coredump settings 2025-07-10 21:32:40 -07:00
Jarred Sumner
5bde8a6c3b Include an Error object in WebSocket error event dispatch (#20957) 2025-07-10 21:28:03 -07:00
Zack Radisic
d733a96ba7 Add LLDB pretty printing for bun.BabyList (#20958) 
Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
 2025-07-10 21:27:03 -07:00
190n
650c8f6d60 cmake: do not accept too-new LLVM versions (#20955) 2025-07-10 18:20:51 -07:00
Alistair Smith
6a62784e89 fix(types): Non-empty TextDecoderStream and TextEncoderStream when outside DOM (#20953) 2025-07-10 17:48:45 -07:00
Meghan Denny
6c5b863530 safety: a lot more exception checker progress (#20817) 2025-07-10 15:34:51 -07:00
taylor.fish
c6bce38ead Fix incorrect negation of isEmpty() in assertion (#20952) 2025-07-10 15:34:46 -07:00
taylor.fish
5a1a3b425c Refactor UnboundedQueue (#20926) 2025-07-10 14:46:10 -07:00
taylor.fish
40c09fdf23 .gitignore: ignore Vim swap files (#20950) 2025-07-10 13:56:02 -07:00
Meghan Denny
055f821a75 webkit: disable libpas on windows (#20931) 2025-07-10 13:37:31 -07:00